rocplot: Individual curve sliders used to be proportional to the range

of the score, which didn't work well for things like GQ / QUAL. Now
based on number of points within the curve. Also, output status bar
accuracy stats during sliding.

Author: Lenbok

src/com/rtg/graph/DataBundle.java

@@ -64,17 +64,15 @@ void setTitle(String title) {
   }
 
   void setScoreRange(float min, float max) {
-    final float smin = mScoreMin + (mScoreMin == mScoreMax ? 0.0f : min * (mScoreMax - mScoreMin));
-    final float smax = mScoreMin + (mScoreMin == mScoreMax ? 0.0f : max * (mScoreMax - mScoreMin));
+    final int smin = (int) (min * mScores.length);
+    final int smax = (int) (max * mScores.length);
 
     final ArrayList<Float> scores = new ArrayList<>();
     final ArrayList<Point2D> points = new ArrayList<>();
 
-    for (int i = 0; i < mScores.length; i++) {
-      if (smin <= mScores[i] && mScores[i] <= smax) {
-        scores.add(mScores[i]);
-        points.add(mPoints[i]);
-      }
+    for (int i = smin; i < smax; i++) {
+      scores.add(mScores[i]);
+      points.add(mPoints[i]);
     }
 
     mRangedPoints = points.toArray(new Point2D[points.size()]);
@@ -134,6 +132,10 @@ private void updateLabels() {
     mRangedPosPoints = posPoints.toArray(new TextPoint2D[posPoints.size()]);
   }
 
+  TextPoint2D getMaxRangedPoint() {
+    return mRangedPosPoints.length == 0 ? null : mRangedPosPoints[mRangedPosPoints.length - 1];
+  }
+
   PointPlot2D getPlot(int lineWidth, int colour) {
     final PointPlot2D lplot = new PointPlot2D();
     lplot.setData(mRangedPoints);

src/com/rtg/graph/RocLinePanel.java

@@ -37,6 +37,7 @@
 import javax.swing.plaf.basic.BasicArrowButton;
 
 import com.reeltwo.jumble.annotations.JumbleIgnore;
+import com.reeltwo.plot.TextPoint2D;
 
 /**
  * A panel that lets you enable or disable showing of a ROC line, rename the ROC line, and has buttons for
@@ -152,8 +153,12 @@ public void mouseClicked(MouseEvent e) {
       @Override
       public void stateChanged(ChangeEvent e) {
         final JSlider slider = (JSlider) e.getSource();
-        mDataBundle.setScoreRange(1.0f - slider.getValue() / 1000.0f, 1.0f);
+        mDataBundle.setScoreRange(0.0f, slider.getValue() / 1000.0f);
         mRocPlot.showCurrentGraph();
+        final TextPoint2D data = mDataBundle.getMaxRangedPoint();
+        if (data != null) {
+          mStatusBar.setString(RocPlot.getTpFpString(data.getY(), data.getX(), mDataBundle.getTotalVariants()) + " Threshold=" + data.getText());
+        }
       }
     });
 

src/com/rtg/graph/RocPlot.java

@@ -523,15 +523,11 @@ public void mouseClicked(MouseEvent e) {
       final Mapping[] mapping = mPlotPanel.getMapping();
       final int maxVariants = ((RocGraph2D) mPlotPanel.getGraph()).getMaxVariants();
       if (mapping != null && mapping.length > 1 && p != null) {
-        final float x = mapping[0].screenToWorld((float) p.getX());
-        final float y = mapping[1].screenToWorld((float) p.getY());
-        if (x >= 0 && y >= 0 && (x + y > 0)) {
-          String message = String.format("TP=%.0f FP=%.0f Precision=%.2f%%", y, x, y / (x + y) * 100);
-          if (maxVariants > 0) {
-            message += String.format(" Sensitivity=%.2f%%", y / maxVariants * 100);
-          }
-          mZoomPP.setCrossHair(new Point((int) x, (int) y));
-          mProgressBar.setString(message);
+        final float fp = mapping[0].screenToWorld((float) p.getX());
+        final float tp = mapping[1].screenToWorld((float) p.getY());
+        if (fp >= 0 && tp >= 0 && (fp + tp > 0)) {
+          mProgressBar.setString(getTpFpString(tp, fp, maxVariants));
+          mZoomPP.setCrossHair(new Point((int) fp, (int) tp));
         } else {
           mZoomPP.setCrossHair(null);
           mProgressBar.setString("");
@@ -556,6 +552,14 @@ private void maybeShowPopup(MouseEvent e) {
     }
   }
 
+  static String getTpFpString(float tp, float fp, int maxVariants) {
+    String message = String.format("TP=%.0f FP=%.0f Precision=%.2f%%", tp, fp, tp / (fp + tp) * 100);
+    if (maxVariants > 0) {
+      message += String.format(" Sensitivity=%.2f%%", tp / maxVariants * 100);
+    }
+    return message;
+  }
+
 
   void rocStandalone(ArrayList<File> fileList, ArrayList<String> nameList, String title, boolean scores, final boolean hideSidePanel, int lineWidth) throws InterruptedException, InvocationTargetException, IOException {
     final RocPlot rp = new RocPlot();