Skip to content

Commit 3d5d050

Browse files
committed
refactor(CoreOperators): update type definition for operator has default parameter value
closes #660
1 parent e9b13d0 commit 3d5d050

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/CoreOperators.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export interface CoreOperators<T> {
2222
dematerialize?: () => Observable<any>;
2323
debounce?: (durationSelector: (value: T) => Observable<any> | Promise<any>) => Observable<T>;
2424
debounceTime?: <R>(dueTime: number, scheduler?: Scheduler) => Observable<R>;
25-
defaultIfEmpty?: <R>(defaultValue: R) => Observable<T> | Observable<R>;
25+
defaultIfEmpty?: <R>(defaultValue?: T | R) => Observable<T> | Observable<R>;
2626
delay?: (delay: number, scheduler?: Scheduler) => Observable<T>;
2727
distinctUntilChanged?: (compare?: (x: T, y: T) => boolean, thisArg?: any) => Observable<T>;
2828
do?: (next?: (x: T) => void, error?: (e: any) => void, complete?: () => void) => Observable<T>;
@@ -50,8 +50,8 @@ export interface CoreOperators<T> {
5050
publishBehavior?: (value: any) => ConnectableObservable<T>;
5151
publishReplay?: (bufferSize: number, windowTime: number, scheduler?: Scheduler) => ConnectableObservable<T>;
5252
reduce?: <R>(project: (acc: R, x: T) => R, seed?: R) => Observable<R>;
53-
repeat?: (count: number) => Observable<T>;
54-
retry?: (count: number) => Observable<T>;
53+
repeat?: (count?: number) => Observable<T>;
54+
retry?: (count?: number) => Observable<T>;
5555
retryWhen?: (notifier: (errors: Observable<any>) => Observable<any>) => Observable<T>;
5656
sample?: (notifier: Observable<any>) => Observable<T>;
5757
sampleTime?: (delay: number, scheduler?: Scheduler) => Observable<T>;

src/Observable.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export default class Observable<T> implements CoreOperators<T> {
170170
dematerialize: () => Observable<any>;
171171
debounce: (durationSelector: (value: T) => Observable<any> | Promise<any>) => Observable<T>;
172172
debounceTime: <R>(dueTime: number, scheduler?: Scheduler) => Observable<R>;
173-
defaultIfEmpty: <R>(defaultValue: R) => Observable<T> | Observable<R>;
173+
defaultIfEmpty: <R>(defaultValue?: T | R) => Observable<T> | Observable<R>;
174174
delay: (delay: number, scheduler?: Scheduler) => Observable<T>;
175175
distinctUntilChanged: (compare?: (x: T, y: T) => boolean, thisArg?: any) => Observable<T>;
176176
do: (next?: (x: T) => void, error?: (e: any) => void, complete?: () => void) => Observable<T>;
@@ -198,8 +198,8 @@ export default class Observable<T> implements CoreOperators<T> {
198198
publishBehavior: (value: any) => ConnectableObservable<T>;
199199
publishReplay: (bufferSize: number, windowTime: number, scheduler?: Scheduler) => ConnectableObservable<T>;
200200
reduce: <R>(project: (acc: R, x: T) => R, seed?: R) => Observable<R>;
201-
repeat: (count: number) => Observable<T>;
202-
retry: (count: number) => Observable<T>;
201+
repeat: (count?: number) => Observable<T>;
202+
retry: (count?: number) => Observable<T>;
203203
retryWhen: (notifier: (errors: Observable<any>) => Observable<any>) => Observable<T>;
204204
sample: (notifier: Observable<any>) => Observable<T>;
205205
sampleTime: (delay: number, scheduler?: Scheduler) => Observable<T>;

0 commit comments

Comments
 (0)