Skip to content

Commit 14cb006

Browse files
style(typings): Updated typings for multicast and publish to return a ConnectableObservable
1 parent 4888b04 commit 14cb006

File tree

6 files changed

+15
-14
lines changed

6 files changed

+15
-14
lines changed

src/operator-typings.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/* tslint:disable:class-name */ /* tslint:disable:no-unused-variable */ /* tslint:disable:max-line-length */
22
import {Observable, ObservableOrPromise, ArrayOrIterator} from './Observable';
3+
import {ConnectableObservable} from './observables/ConnectableObservable';
34
import {Scheduler} from './Scheduler';
45
import {Notification} from './Notification';
56
import {Subject} from './Subject';
@@ -163,7 +164,7 @@ export interface operator_proto_mergeAll<T> {
163164
<R>(concurrent: number): Observable<R>;
164165
}
165166
export interface operator_proto_multicast<T> {
166-
(subjectOrSubjectFactory: Subject<T> | (() => Subject<T>)): Observable<T>;
167+
(subjectOrSubjectFactory: Subject<T> | (() => Subject<T>)): ConnectableObservable<T>;
167168
}
168169
export interface operator_proto_observeOn<T> {
169170
(scheduler: Scheduler, delay?: number): Observable<T>;
@@ -172,13 +173,13 @@ export interface operator_proto_partition<T> {
172173
(predicate: _Predicate<T>, thisArg?: any): Observable<[T, T]>;
173174
}
174175
export interface operator_proto_publish<T> {
175-
(): Observable<T>;
176+
(): ConnectableObservable<T>;
176177
}
177178
export interface operator_proto_publishBehavior<T> {
178-
(value: T): Observable<T>;
179+
(value: T): ConnectableObservable<T>;
179180
}
180181
export interface operator_proto_publishReplay<T> {
181-
(bufferSize?: number, windowTime?: number, scheduler?: Scheduler): Observable<T>;
182+
(bufferSize?: number, windowTime?: number, scheduler?: Scheduler): ConnectableObservable<T>;
182183
}
183184
export interface operator_proto_reduce<T> {
184185
<R>(project: _Accumulator<T, R>, seed?: R): Observable<R>;

src/operators/multicast.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import {Observable} from '../Observable';
21
import {Subject} from '../Subject';
32
import {ConnectableObservable} from '../observables/ConnectableObservable';
43

5-
export function multicast<T>(subjectOrSubjectFactory: Subject<T> | (() => Subject<T>)): Observable<T> {
4+
export function multicast<T>(subjectOrSubjectFactory: Subject<T> | (() => Subject<T>)): ConnectableObservable<T> {
65
let subjectFactory: () => Subject<T>;
76
if (typeof subjectOrSubjectFactory === 'function') {
87
subjectFactory = <() => Subject<T>>subjectOrSubjectFactory;

src/operators/publish.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import {Observable} from '../Observable';
1+
import {ConnectableObservable} from '../observables/ConnectableObservable';
22
import {Subject} from '../Subject';
33
import {multicast} from './multicast';
44

5-
export function publish<T>(): Observable<T> {
5+
export function publish<T>(): ConnectableObservable<T> {
66
return multicast.call(this, new Subject());
77
}

src/operators/publishBehavior.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import {Observable} from '../Observable';
1+
import {ConnectableObservable} from '../observables/ConnectableObservable';
22
import {BehaviorSubject} from '../subjects/BehaviorSubject';
33
import {multicast} from './multicast';
44

5-
export function publishBehavior<T>(value: T): Observable<T> {
5+
export function publishBehavior<T>(value: T): ConnectableObservable<T> {
66
return multicast.call(this, new BehaviorSubject(value));
77
}

src/operators/publishReplay.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import {Observable} from '../Observable';
1+
import {ConnectableObservable} from '../observables/ConnectableObservable';
22
import {ReplaySubject} from '../subjects/ReplaySubject';
33
import {Scheduler} from '../Scheduler';
44
import {multicast} from './multicast';
55

6-
export function publishReplay<T>(bufferSize?: number, windowTime?: number, scheduler?: Scheduler): Observable<T>;
6+
export function publishReplay<T>(bufferSize?: number, windowTime?: number, scheduler?: Scheduler): ConnectableObservable<T>;
77
export function publishReplay<T>(bufferSize: number = Number.POSITIVE_INFINITY,
88
windowTime: number = Number.POSITIVE_INFINITY,
9-
scheduler?: Scheduler): Observable<T> {
9+
scheduler?: Scheduler): ConnectableObservable<T> {
1010
return multicast.call(this, new ReplaySubject(bufferSize, windowTime, scheduler));
1111
}

typingsgen.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ var extraSpaceRegex = / /;
1010
var operators = {};
1111
var fileResult = '/* tslint:disable:class-name */ /* tslint:disable:no-unused-variable */ /* tslint:disable:max-line-length */\n\
1212
import {Observable, ObservableOrPromise, ArrayOrIterator} from \'./Observable\';\n\
13+
import {ConnectableObservable} from \'./observables/ConnectableObservable\';\n\
1314
import {Scheduler} from \'./Scheduler\';\n\
1415
import {Notification} from \'./Notification\';\n\
1516
import {Subject} from \'./Subject\';\n\
@@ -36,7 +37,7 @@ for (var i = 0; i < contents.length; i++) {
3637
} else {
3738
var fileContent = fs.readFileSync('./src/operators/extended/'+filename+'.ts').toString();
3839
}
39-
40+
4041
var methods = [];
4142

4243
var r = new RegExp('export function [_]?'+ filename +'([\\s|\\S]*?[\\;\\{])', 'g');

0 commit comments

Comments
 (0)