Skip to content

Commit d07dfa1

Browse files
authored
2.x: improve JavaDocs of the subscribeActual methods (#5981)
1 parent a1b9628 commit d07dfa1

File tree

5 files changed

+20
-9
lines changed

5 files changed

+20
-9
lines changed

src/main/java/io/reactivex/Completable.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1927,8 +1927,11 @@ public final void subscribe(CompletableObserver s) {
19271927
}
19281928

19291929
/**
1930-
* Implement this to handle the incoming CompletableObserver and
1930+
* Implement this method to handle the incoming {@link CompletableObserver}s and
19311931
* perform the business logic in your operator.
1932+
* <p>There is no need to call any of the plugin hooks on the current {@code Completable} instance or
1933+
* the {@code CompletableObserver}; all hooks and basic safeguards have been
1934+
* applied by {@link #subscribe(CompletableObserver)} before this method gets called.
19321935
* @param s the CompletableObserver instance, never null
19331936
*/
19341937
protected abstract void subscribeActual(CompletableObserver s);

src/main/java/io/reactivex/Flowable.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14333,9 +14333,10 @@ public final void subscribe(FlowableSubscriber<? super T> s) {
1433314333

1433414334
/**
1433514335
* Operator implementations (both source and intermediate) should implement this method that
14336-
* performs the necessary business logic.
14337-
* <p>There is no need to call any of the plugin hooks on the current Flowable instance or
14338-
* the Subscriber.
14336+
* performs the necessary business logic and handles the incoming {@link Subscriber}s.
14337+
* <p>There is no need to call any of the plugin hooks on the current {@code Flowable} instance or
14338+
* the {@code Subscriber}; all hooks and basic safeguards have been
14339+
* applied by {@link #subscribe(Subscriber)} before this method gets called.
1433914340
* @param s the incoming Subscriber, never null
1434014341
*/
1434114342
protected abstract void subscribeActual(Subscriber<? super T> s);

src/main/java/io/reactivex/Maybe.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4082,7 +4082,10 @@ public final void subscribe(MaybeObserver<? super T> observer) {
40824082
}
40834083

40844084
/**
4085-
* Override this method in subclasses to handle the incoming MaybeObservers.
4085+
* Implement this method in subclasses to handle the incoming {@link MaybeObserver}s.
4086+
* <p>There is no need to call any of the plugin hooks on the current {@code Maybe} instance or
4087+
* the {@code MaybeObserver}; all hooks and basic safeguards have been
4088+
* applied by {@link #subscribe(MaybeObserver)} before this method gets called.
40864089
* @param observer the MaybeObserver to handle, not null
40874090
*/
40884091
protected abstract void subscribeActual(MaybeObserver<? super T> observer);

src/main/java/io/reactivex/Observable.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12039,9 +12039,10 @@ public final void subscribe(Observer<? super T> observer) {
1203912039

1204012040
/**
1204112041
* Operator implementations (both source and intermediate) should implement this method that
12042-
* performs the necessary business logic.
12043-
* <p>There is no need to call any of the plugin hooks on the current Observable instance or
12044-
* the Subscriber.
12042+
* performs the necessary business logic and handles the incoming {@link Observer}s.
12043+
* <p>There is no need to call any of the plugin hooks on the current {@code Observable} instance or
12044+
* the {@code Observer}; all hooks and basic safeguards have been
12045+
* applied by {@link #subscribe(Observer)} before this method gets called.
1204512046
* @param observer the incoming Observer, never null
1204612047
*/
1204712048
protected abstract void subscribeActual(Observer<? super T> observer);

src/main/java/io/reactivex/Single.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3304,7 +3304,10 @@ public final void subscribe(SingleObserver<? super T> subscriber) {
33043304
}
33053305

33063306
/**
3307-
* Override this method in subclasses to handle the incoming SingleObservers.
3307+
* Implement this method in subclasses to handle the incoming {@link SingleObserver}s.
3308+
* <p>There is no need to call any of the plugin hooks on the current {@code Single} instance or
3309+
* the {@code SingleObserver}; all hooks and basic safeguards have been
3310+
* applied by {@link #subscribe(SingleObserver)} before this method gets called.
33083311
* @param observer the SingleObserver to handle, not null
33093312
*/
33103313
protected abstract void subscribeActual(@NonNull SingleObserver<? super T> observer);

0 commit comments

Comments
 (0)