Skip to content

Commit a797c56

Browse files
Merge pull request #821 from benjchristensen/fix-android-merge
Update to use Subscriber/Subscriptions.create
2 parents 20bbe7c + b1a7711 commit a797c56

File tree

3 files changed

+33
-26
lines changed

3 files changed

+33
-26
lines changed

rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperatorCompoundButtonInput.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,19 @@
1515
*/
1616
package rx.operators;
1717

18-
import android.view.View;
19-
import android.widget.CompoundButton;
20-
import rx.Observable;
21-
import rx.Observer;
22-
import rx.Subscription;
23-
2418
import java.util.ArrayList;
2519
import java.util.List;
2620
import java.util.Map;
2721
import java.util.WeakHashMap;
2822

23+
import rx.Observable;
24+
import rx.Subscriber;
25+
import rx.Subscription;
26+
import rx.subscriptions.Subscriptions;
27+
import rx.util.functions.Action0;
28+
import android.view.View;
29+
import android.widget.CompoundButton;
30+
2931
public class OperatorCompoundButtonInput implements Observable.OnSubscribe<Boolean> {
3032
private final boolean emitInitialValue;
3133
private final CompoundButton button;
@@ -36,7 +38,7 @@ public OperatorCompoundButtonInput(final CompoundButton button, final boolean em
3638
}
3739

3840
@Override
39-
public void call(final Observer<? super Boolean> observer) {
41+
public void call(final Subscriber<? super Boolean> observer) {
4042
final CompositeOnCheckedChangeListener composite = CachedListeners.getFromViewOrCreate(button);
4143

4244
final CompoundButton.OnCheckedChangeListener listener = new CompoundButton.OnCheckedChangeListener() {
@@ -46,12 +48,12 @@ public void onCheckedChanged(final CompoundButton button, final boolean checked)
4648
}
4749
};
4850

49-
final Subscription subscription = new Subscription() {
51+
final Subscription subscription = Subscriptions.create(new Action0() {
5052
@Override
51-
public void unsubscribe() {
53+
public void call() {
5254
composite.removeOnCheckedChangeListener(listener);
5355
}
54-
};
56+
});
5557

5658
if (emitInitialValue) {
5759
observer.onNext(button.isChecked());

rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperatorEditTextInput.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@
1515
*/
1616
package rx.operators;
1717

18+
import rx.Observable;
19+
import rx.Subscriber;
20+
import rx.Subscription;
21+
import rx.subscriptions.Subscriptions;
22+
import rx.util.functions.Action0;
1823
import android.text.Editable;
1924
import android.text.TextWatcher;
2025
import android.widget.EditText;
21-
import rx.Observable;
22-
import rx.Observer;
23-
import rx.Subscription;
2426

2527
public class OperatorEditTextInput implements Observable.OnSubscribe<String> {
2628
private final EditText input;
@@ -32,20 +34,20 @@ public OperatorEditTextInput(final EditText input, final boolean emitInitialValu
3234
}
3335

3436
@Override
35-
public void call(final Observer<? super String> observer) {
37+
public void call(final Subscriber<? super String> observer) {
3638
final TextWatcher watcher = new SimpleTextWatcher() {
3739
@Override
3840
public void afterTextChanged(final Editable editable) {
3941
observer.onNext(editable.toString());
4042
}
4143
};
42-
43-
final Subscription subscription = new Subscription() {
44+
45+
final Subscription subscription = Subscriptions.create(new Action0() {
4446
@Override
45-
public void unsubscribe() {
47+
public void call() {
4648
input.removeTextChangedListener(watcher);
4749
}
48-
};
50+
});
4951

5052
if (emitInitialValue) {
5153
observer.onNext(input.getEditableText().toString());

rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperatorViewClick.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,18 @@
1515
*/
1616
package rx.operators;
1717

18-
import android.view.View;
19-
import rx.Observable;
20-
import rx.Observer;
21-
import rx.Subscription;
2218
import java.util.ArrayList;
2319
import java.util.List;
2420
import java.util.Map;
2521
import java.util.WeakHashMap;
2622

23+
import rx.Observable;
24+
import rx.Subscriber;
25+
import rx.Subscription;
26+
import rx.subscriptions.Subscriptions;
27+
import rx.util.functions.Action0;
28+
import android.view.View;
29+
2730
public final class OperatorViewClick implements Observable.OnSubscribe<View> {
2831
private final boolean emitInitialValue;
2932
private final View view;
@@ -34,7 +37,7 @@ public OperatorViewClick(final View view, final boolean emitInitialValue) {
3437
}
3538

3639
@Override
37-
public void call(final Observer<? super View> observer) {
40+
public void call(final Subscriber<? super View> observer) {
3841
final CompositeOnClickListener composite = CachedListeners.getFromViewOrCreate(view);
3942

4043
final View.OnClickListener listener = new View.OnClickListener() {
@@ -44,12 +47,12 @@ public void onClick(final View clicked) {
4447
}
4548
};
4649

47-
final Subscription subscription = new Subscription() {
50+
final Subscription subscription = Subscriptions.create(new Action0() {
4851
@Override
49-
public void unsubscribe() {
52+
public void call() {
5053
composite.removeOnClickListener(listener);
5154
}
52-
};
55+
});
5356

5457
if (emitInitialValue) {
5558
observer.onNext(view);

0 commit comments

Comments
 (0)