Skip to content

Commit 91292a3

Browse files
committed
Merge pull request #3512 from akarnokd/SafeSubscriberDocFix
1.x: fix SafeSubscriber documentation regarding unsubscribe
2 parents 32de6fc + d153d71 commit 91292a3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/rx/observers/SafeSubscriber.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
* <ul>
5151
* <li>Allows only single execution of either {@code onError} or {@code onCompleted}.</li>
5252
* <li>Ensures that once an {@code onCompleted} or {@code onError} is performed, no further calls can be executed</li>
53-
* <li>If {@code unsubscribe} is called, calls {@code onCompleted} and forbids any further {@code onNext} calls.</li>
53+
* <li>If {@code unsubscribe} is called, the upstream {@code Observable} is notified and the event delivery will be stopped in a
54+
* best effort manner (i.e., further onXXX calls may still slip through).</li>
5455
* <li>When {@code onError} or {@code onCompleted} occur, unsubscribes from the {@code Observable} (if executing asynchronously).</li>
5556
* </ul>
5657
* {@code SafeSubscriber} will not synchronize {@code onNext} execution. Use {@link SerializedSubscriber} to do

0 commit comments

Comments
 (0)