Skip to content

Commit 82bc2de

Browse files
committed
Clarify OperatorTextViewInputTest methods
1 parent b338afa commit 82bc2de

File tree

1 file changed

+22
-9
lines changed

1 file changed

+22
-9
lines changed

rxjava-contrib/rxjava-android/src/test/java/rx/android/operators/OperatorTextViewInputTest.java

+22-9
Original file line numberDiff line numberDiff line change
@@ -63,22 +63,35 @@ private static EditText createEditText(final String value) {
6363
public void testOverloadedMethodDefaultsWithoutInitialValue() {
6464
final TextView input = createTextView("initial");
6565
final Observable<TextView> observable = ViewObservable.text(input);
66-
runWithoutInitialValueTest(input, observable);
66+
final Observer<TextView> observer = mock(Observer.class);
67+
final Subscription subscription = observable.subscribe(new TestObserver<TextView>(observer));
68+
69+
final InOrder inOrder = inOrder(observer);
70+
71+
inOrder.verify(observer, never()).onNext(any(TextView.class));
72+
73+
input.setText("1");
74+
inOrder.verify(observer, times(1)).onNext(input);
75+
76+
input.setText("2");
77+
inOrder.verify(observer, times(1)).onNext(input);
78+
79+
input.setText("3");
80+
inOrder.verify(observer, times(1)).onNext(input);
81+
82+
subscription.unsubscribe();
83+
input.setText("4");
84+
inOrder.verify(observer, never()).onNext(any(TextView.class));
85+
86+
inOrder.verify(observer, never()).onError(any(Throwable.class));
87+
inOrder.verify(observer, never()).onCompleted();
6788
}
6889

6990
@Test
7091
@SuppressWarnings("unchecked")
7192
public void testWithoutInitialValue() {
7293
final TextView input = createTextView("initial");
7394
final Observable<TextView> observable = ViewObservable.text(input, false);
74-
runWithoutInitialValueTest(input, observable);
75-
}
76-
77-
/**
78-
* Helper method to run {@link #testOverloadedMethodDefaultsWithoutInitialValue} and
79-
* {@link #testWithoutInitialValue} which test the same functionality.
80-
*/
81-
private void runWithoutInitialValueTest(final TextView input, final Observable<TextView> observable) {
8295
final Observer<TextView> observer = mock(Observer.class);
8396
final Subscription subscription = observable.subscribe(new TestObserver<TextView>(observer));
8497

0 commit comments

Comments
 (0)