Skip to content

Commit 6725754

Browse files
Fix OperationalConditional
All unit tests now pass.
1 parent 9ee0fdc commit 6725754

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

rxjava-contrib/rxjava-computation-expressions/src/main/java/rx/operators/OperationConditionals.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import rx.Observable.OnSubscribeFunc;
2222
import rx.Observer;
2323
import rx.Subscription;
24+
import rx.subscriptions.MultipleAssignmentSubscription;
2425
import rx.subscriptions.SerialSubscription;
2526
import rx.subscriptions.Subscriptions;
2627
import rx.util.functions.Func0;
@@ -231,7 +232,7 @@ public Subscription onSubscribe(Observer<? super T> t1) {
231232
return Subscriptions.empty();
232233
}
233234
if (first) {
234-
SerialSubscription ssub = new SerialSubscription();
235+
MultipleAssignmentSubscription ssub = new MultipleAssignmentSubscription();
235236

236237
ssub.set(source.subscribe(new SourceObserver(t1, ssub)));
237238

@@ -244,10 +245,10 @@ public Subscription onSubscribe(Observer<? super T> t1) {
244245

245246
/** Observe the source. */
246247
final class SourceObserver extends Observer<T> {
247-
final SerialSubscription cancel;
248+
final MultipleAssignmentSubscription cancel;
248249
final Observer<? super T> observer;
249250

250-
public SourceObserver(Observer<? super T> observer, SerialSubscription cancel) {
251+
public SourceObserver(Observer<? super T> observer, MultipleAssignmentSubscription cancel) {
251252
this.observer = observer;
252253
this.cancel = cancel;
253254
}

rxjava-contrib/rxjava-computation-expressions/src/test/java/rx/operators/OperationConditionalsTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ public Boolean call() {
403403

404404
@Test
405405
public void testDoWhileManyTimes() {
406-
fail("deadlocking");
407406
Observable<Integer> source1 = Observable.from(1, 2, 3).subscribeOn(Schedulers.currentThread());
408407

409408
List<Integer> expected = new ArrayList<Integer>(numRecursion * 3);

0 commit comments

Comments
 (0)