Skip to content

Commit 1b24634

Browse files
committed
add never test for PublishSuibjectText
1 parent 6aa760e commit 1b24634

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

src/test/java/rx/subjects/PublishSubjectTest.java

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void testCompleted() {
6363
subject.onError(new Throwable());
6464

6565
assertCompletedObserver(observer);
66-
// todo bug? assertNeverObserver(anotherObserver);
66+
assertNeverObserver(anotherObserver);
6767
}
6868

6969
@Test
@@ -113,6 +113,16 @@ private void assertCompletedObserver(Observer<String> observer) {
113113
verify(observer, times(1)).onNext("one");
114114
verify(observer, times(1)).onNext("two");
115115
verify(observer, times(1)).onNext("three");
116+
verify(observer, never()).onNext("four");
117+
verify(observer, never()).onError(any(Throwable.class));
118+
verify(observer, times(1)).onCompleted();
119+
}
120+
121+
private void assertNeverObserver(Observer<String> observer) {
122+
verify(observer, never()).onNext("one");
123+
verify(observer, never()).onNext("two");
124+
verify(observer, never()).onNext("three");
125+
verify(observer, never()).onNext("four");
116126
verify(observer, never()).onError(any(Throwable.class));
117127
verify(observer, times(1)).onCompleted();
118128
}
@@ -139,7 +149,7 @@ public void testError() {
139149
subject.onCompleted();
140150

141151
assertErrorObserver(observer);
142-
// todo bug? assertNeverObserver(anotherObserver);
152+
assertNeverErrorObserver(anotherObserver);
143153
}
144154

145155
private void assertErrorObserver(Observer<String> observer) {
@@ -150,6 +160,15 @@ private void assertErrorObserver(Observer<String> observer) {
150160
verify(observer, never()).onCompleted();
151161
}
152162

163+
private void assertNeverErrorObserver(Observer<String> observer) {
164+
verify(observer, never()).onNext("one");
165+
verify(observer, never()).onNext("two");
166+
verify(observer, never()).onNext("three");
167+
verify(observer, never()).onNext("four");
168+
verify(observer, times(1)).onError(any(Throwable.class));
169+
verify(observer, never()).onCompleted();
170+
}
171+
153172
@Test
154173
public void testSubscribeMidSequence() {
155174
PublishSubject<String> subject = PublishSubject.create();

0 commit comments

Comments
 (0)