Skip to content

Commit e3f9948

Browse files
committed
Update detekt config, remove kotlin-dsl.
1 parent fc25a1d commit e3f9948

File tree

8 files changed

+15
-24
lines changed

8 files changed

+15
-24
lines changed

android/foundation/designsystem/src/main/kotlin/io/github/reactivecircus/kstreamlined/android/foundation/designsystem/preview/PreviewKStreamlined.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public annotation class PreviewKStreamlined
1212

1313
@Composable
1414
public fun KSThemeWithSurface(
15-
content: @Composable () -> Unit
15+
content: @Composable () -> Unit,
1616
) {
1717
KSTheme {
1818
Surface {

build-logic/cocoon/cocoon-compiler-plugin/build.gradle.kts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import io.gitlab.arturbosch.detekt.Detekt
1+
import dev.detekt.gradle.Detekt
22
import org.gradle.kotlin.dsl.withType
33
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
44
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
@@ -31,23 +31,21 @@ detekt {
3131
source.from(files("src/"))
3232
config.from(files("$rootDir/../detekt.yml"))
3333
buildUponDefaultConfig = true
34-
allRules = true
3534
parallel = true
3635
}
3736

3837
tasks.withType<Detekt>().configureEach {
3938
jvmTarget = JvmTarget.JVM_11.target
4039
reports {
4140
xml.required.set(false)
42-
txt.required.set(false)
4341
sarif.required.set(false)
4442
md.required.set(false)
4543
}
4644
}
4745

4846
dependencies {
4947
// enable Ktlint formatting
50-
add("detektPlugins", libs.plugin.detektFormatting)
48+
detektPlugins(libs.plugin.detektKtlintWrapper)
5149

5250
compileOnly(libs.kotlin.compiler)
5351
compileOnly(libs.kotlin.stblib)

build-logic/cocoon/cocoon-compiler-plugin/src/main/kotlin/io/github/reactivecircus/cocoon/compiler/CocoonCommandLineProcessor.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import org.jetbrains.kotlin.config.CompilerConfiguration
77
import org.jetbrains.kotlin.config.CompilerConfigurationKey
88

99
public class CocoonCommandLineProcessor : CommandLineProcessor {
10-
1110
override val pluginId: String = "io.github.reactivecircus.cocoon.compiler"
1211

1312
@Suppress("MaxLineLength")

build-logic/cocoon/cocoon-compiler-plugin/src/main/kotlin/io/github/reactivecircus/cocoon/compiler/CocoonCompilerPluginRegistrar.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,30 @@ import org.jetbrains.kotlin.config.CommonConfigurationKeys
77
import org.jetbrains.kotlin.config.CompilerConfiguration
88

99
public class CocoonCompilerPluginRegistrar : CompilerPluginRegistrar() {
10-
1110
override val supportsK2: Boolean = true
1211

1312
override fun ExtensionStorage.registerExtensions(configuration: CompilerConfiguration) {
1413
val annotationString = requireNotNull(
15-
configuration.get(CocoonCommandLineProcessor.CompilerOptions.Annotation)
14+
configuration.get(CocoonCommandLineProcessor.CompilerOptions.Annotation),
1615
)
1716
val annotationClassId = annotationString.toClassId()
1817

1918
val wrappingFunctionString = requireNotNull(
20-
configuration.get(CocoonCommandLineProcessor.CompilerOptions.WrappingFunction)
19+
configuration.get(CocoonCommandLineProcessor.CompilerOptions.WrappingFunction),
2120
)
2221
val wrappingFunctionCallableId = wrappingFunctionString.toCallableId()
2322

2423
val messageCollector = configuration.get(
2524
CommonConfigurationKeys.MESSAGE_COLLECTOR_KEY,
26-
MessageCollector.NONE
25+
MessageCollector.NONE,
2726
)
2827

2928
IrGenerationExtension.registerExtension(
3029
extension = CocoonIrGenerationExtension(
3130
annotationName = annotationClassId,
3231
wrappingFunctionName = wrappingFunctionCallableId,
3332
messageCollector = messageCollector,
34-
)
33+
),
3534
)
3635
}
3736
}

build-logic/cocoon/cocoon-compiler-plugin/src/main/kotlin/io/github/reactivecircus/cocoon/compiler/CocoonFunctionTransformer.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ internal class CocoonFunctionTransformer(
3333
private val annotation: ClassId,
3434
private val wrappingFunction: CallableId,
3535
) : IrElementTransformerVoidWithContext() {
36-
3736
@OptIn(UnsafeDuringIrConstructionAPI::class)
3837
override fun visitFunctionNew(declaration: IrFunction): IrStatement {
3938
if (!declaration.hasAnnotation(annotation) || declaration.body == null) {
@@ -72,7 +71,7 @@ internal class CocoonFunctionTransformer(
7271
}
7372
arguments[wrappingFunctionParameters.size - 1] = lambdaExpression
7473
}
75-
}
74+
},
7675
)
7776
}
7877

build-logic/cocoon/cocoon-gradle-plugin/build.gradle.kts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
import io.gitlab.arturbosch.detekt.Detekt
1+
import dev.detekt.gradle.Detekt
22
import org.gradle.kotlin.dsl.withType
33
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
44
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
55

66
plugins {
7-
`kotlin-dsl`
7+
`java-gradle-plugin`
8+
alias(libs.plugins.kotlin.jvm)
89
alias(libs.plugins.detekt)
910
}
1011

@@ -36,23 +37,21 @@ detekt {
3637
source.from(files("src/"))
3738
config.from(files("$rootDir/../detekt.yml"))
3839
buildUponDefaultConfig = true
39-
allRules = true
4040
parallel = true
4141
}
4242

4343
tasks.withType<Detekt>().configureEach {
4444
jvmTarget = JvmTarget.JVM_11.target
4545
reports {
4646
xml.required.set(false)
47-
txt.required.set(false)
4847
sarif.required.set(false)
4948
md.required.set(false)
5049
}
5150
}
5251

5352
dependencies {
5453
// enable Ktlint formatting
55-
add("detektPlugins", libs.plugin.detektFormatting)
54+
detektPlugins(libs.plugin.detektKtlintWrapper)
5655

5756
compileOnly(libs.plugin.kotlin)
5857
}

build-logic/cocoon/cocoon-gradle-plugin/src/main/kotlin/io/github/reactivecircus/cocoon/gradle/CocoonExtension.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ package io.github.reactivecircus.cocoon.gradle
22

33
import org.gradle.api.model.ObjectFactory
44
import org.gradle.api.provider.Property
5-
import org.gradle.kotlin.dsl.property
65

76
public abstract class CocoonExtension internal constructor(objects: ObjectFactory) {
8-
public val annotation: Property<String> = objects.property<String>()
9-
public val wrappingFunction: Property<String> = objects.property<String>()
7+
public val annotation: Property<String> = objects.property(String::class.java)
8+
public val wrappingFunction: Property<String> = objects.property(String::class.java)
109
}

build-logic/cocoon/cocoon-gradle-plugin/src/main/kotlin/io/github/reactivecircus/cocoon/gradle/CocoonPlugin.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,19 @@ package io.github.reactivecircus.cocoon.gradle
22

33
import org.gradle.api.Project
44
import org.gradle.api.provider.Provider
5-
import org.gradle.kotlin.dsl.getByType
65
import org.jetbrains.kotlin.gradle.plugin.KotlinCompilation
76
import org.jetbrains.kotlin.gradle.plugin.KotlinCompilerPluginSupportPlugin
87
import org.jetbrains.kotlin.gradle.plugin.SubpluginArtifact
98
import org.jetbrains.kotlin.gradle.plugin.SubpluginOption
109

1110
public class CocoonPlugin : KotlinCompilerPluginSupportPlugin {
12-
1311
override fun apply(target: Project) {
1412
target.extensions.create("cocoon", CocoonExtension::class.java)
1513
}
1614

1715
override fun applyToCompilation(kotlinCompilation: KotlinCompilation<*>): Provider<List<SubpluginOption>> {
1816
val project = kotlinCompilation.target.project
19-
val extension = project.extensions.getByType<CocoonExtension>()
17+
val extension = project.extensions.getByType(CocoonExtension::class.java)
2018
return project.provider {
2119
listOf(
2220
SubpluginOption(

0 commit comments

Comments
 (0)