Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of calls to logpdf is not niterations * nsamples #34

Open
wouterwln opened this issue Aug 23, 2024 · 2 comments
Open

Number of calls to logpdf is not niterations * nsamples #34

wouterwln opened this issue Aug 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@wouterwln
Copy link
Member

See https://github.com/ReactiveBayes/ExponentialFamilyProjection.jl/tree/iterations-bug for a test showcasing this bug
@wouterwln wouterwln added the bug Something isn't working label Aug 23, 2024
@bvdmitri
Copy link
Member

I doesn't seem like a bug because the number of calls can be fewer than niterations * nsamples when the projection converges more quickly and requires less iterations due to the tolerance setting. In your test, since you're using a simple function (return 0.0), it likely converges in just one (or few) iteration. To test this hypothesis, you could try setting tolerance = missing.

@bvdmitri
Copy link
Member

We can design a test with tolerance = missing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvdmitri @wouterwln