Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

Commit 21710d0

Browse files
Fixing examples
1 parent a59af1f commit 21710d0

10 files changed

+33
-36
lines changed

dist/rx.dom.compat.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@
796796

797797
function noop() {}
798798

799-
var tasks = new Array(1000), taskId = 0, scheduleMethod, clearMethod = noop;
799+
var tasks = [], taskId = 0, scheduleMethod, clearMethod = noop;
800800

801801
var setImmediate = root.setImmediate, clearImmediate = root.clearImmediate;
802802

@@ -817,8 +817,7 @@
817817
if (!!BrowserMutationObserver) {
818818

819819
var observer = new BrowserMutationObserver(function() {
820-
var toProcess = queue.slice(0);
821-
queue = new Array(1000);
820+
var toProcess = tasks.slice(0);
822821

823822
toProcess.forEach(function (func) {
824823
func();
@@ -835,14 +834,14 @@
835834
}, false);
836835

837836
scheduleMethod = function (action) {
838-
var id = queueId++;
839-
queue[id] = action;
837+
var id = taskId++;
838+
tasks[id] = action;
840839
element.setAttribute('drainQueue', 'drainQueue');
841840
return id;
842841
};
843842

844843
var clearMethod = function(id) {
845-
queue[id] = undefined;
844+
delete tasks[id];
846845
};
847846
} else if (typeof setImmediate === 'function') {
848847
scheduleMethod = setImmediate;

dist/rx.dom.compat.map

+1-1
Large diffs are not rendered by default.

dist/rx.dom.compat.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rx.dom.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,7 @@
718718

719719
function noop() {}
720720

721-
var tasks = new Array(1000), taskId = 0, scheduleMethod, clearMethod = noop;
721+
var tasks = [], taskId = 0, scheduleMethod, clearMethod = noop;
722722

723723
var setImmediate = root.setImmediate, clearImmediate = root.clearImmediate;
724724

@@ -739,8 +739,7 @@
739739
if (!!BrowserMutationObserver) {
740740

741741
var observer = new BrowserMutationObserver(function() {
742-
var toProcess = queue.slice(0);
743-
queue = new Array(1000);
742+
var toProcess = tasks.slice(0);
744743

745744
toProcess.forEach(function (func) {
746745
func();
@@ -757,14 +756,14 @@
757756
}, false);
758757

759758
scheduleMethod = function (action) {
760-
var id = queueId++;
761-
queue[id] = action;
759+
var id = taskId++;
760+
tasks[id] = action;
762761
element.setAttribute('drainQueue', 'drainQueue');
763762
return id;
764763
};
765764

766765
var clearMethod = function(id) {
767-
queue[id] = undefined;
766+
delete tasks[id];
768767
};
769768
} else if (typeof setImmediate === 'function') {
770769
scheduleMethod = setImmediate;

dist/rx.dom.map

+1-1
Large diffs are not rendered by default.

dist/rx.dom.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/Autocomplete/autocomplete.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
}
88

99
function clearChildren (e) {
10-
while (e.firstChild) { e.removeChild(e.firstChild); }
10+
while (e.firstChild) { e.removeChild(e.firstChild); }
1111
}
1212

1313
function createChildren(results, parent) {
1414
for (var i = 0, len = results.length; i < len; i++) {
1515
createElement(results[i], parent);
16-
}
16+
}
1717
}
1818

1919
function createElement(text, parent) {
@@ -25,20 +25,20 @@
2525
function initialize () {
2626
var input = document.getElementById('textInput'),
2727
ul = document.getElementById('results');
28-
28+
2929
var keyup = Rx.DOM.keyup(input)
3030
.map(function (ev) { return ev.target.value; })
3131
.filter(function(text) { return text.length > 2; })
32-
.throttle(500)
32+
.debounce(500)
3333
.distinctUntilChanged();
3434

35-
var searcher = keyup.flatMapLatest(searchWikipedia).map(function(d) { return d[1]; });
35+
var searcher = keyup.flatMapLatest(searchWikipedia).map(function(d) { return d.response[1]; });
3636

3737
searcher.subscribe(
38-
function (results) {
38+
function (results) {
3939
clearChildren(ul);
4040
createChildren(results, ul);
41-
},
41+
},
4242
function (error) {
4343
clearChildren(ul);
4444
createElement('Error: ' + error.message, ul);
@@ -47,4 +47,4 @@
4747
}
4848

4949
Rx.DOM.ready().subscribe(initialize);
50-
}(window));
50+
}(window));

examples/CORS/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
});
1414

1515
request.subscribe(
16-
function (xhr) {
17-
result.textContent = 'Page Title: ' + getTitle(xhr.responseText);
16+
function (x) {
17+
result.textContent = 'Page Title: ' + getTitle(x.xhr.responseText);
1818
},
1919
function (err) {
20-
result.textContent = 'Error response: ' + xhr.message;
20+
result.textContent = 'Error response: ' + err;
2121
}
2222
)
2323
}

examples/mutationobserver/mutationobserverscheduler.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
function initialize() {
44
var ul = document.getElementById('results');
55

6-
Rx.Observable.range(0, 10, Rx.Scheduler.mutationObserver)
6+
Rx.Observable.range(0, 10, Rx.Scheduler.microtask)
77
.subscribe(function (results) {
88
var li = document.createElement('li');
99
li.innerHTML = results;
10-
ul.appendChild(li);
10+
ul.appendChild(li);
1111
});
1212
}
1313

1414
Rx.DOM.ready().subscribe(initialize);
1515

16-
}(window));
16+
}(window));

src/microtaskscheduler.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
function noop() {}
77

8-
var tasks = new Array(1000), taskId = 0, scheduleMethod, clearMethod = noop;
8+
var tasks = [], taskId = 0, scheduleMethod, clearMethod = noop;
99

1010
var setImmediate = root.setImmediate, clearImmediate = root.clearImmediate;
1111

@@ -26,8 +26,7 @@
2626
if (!!BrowserMutationObserver) {
2727

2828
var observer = new BrowserMutationObserver(function() {
29-
var toProcess = queue.slice(0);
30-
queue = new Array(1000);
29+
var toProcess = tasks.slice(0);
3130

3231
toProcess.forEach(function (func) {
3332
func();
@@ -44,14 +43,14 @@
4443
}, false);
4544

4645
scheduleMethod = function (action) {
47-
var id = queueId++;
48-
queue[id] = action;
46+
var id = taskId++;
47+
tasks[id] = action;
4948
element.setAttribute('drainQueue', 'drainQueue');
5049
return id;
5150
};
5251

5352
var clearMethod = function(id) {
54-
queue[id] = undefined;
53+
delete tasks[id];
5554
};
5655
} else if (typeof setImmediate === 'function') {
5756
scheduleMethod = setImmediate;

0 commit comments

Comments
 (0)