Skip to content

[BUG] Children are not cleaned from memory #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamil-sienkiewicz-asi opened this issue Feb 28, 2025 · 2 comments
Open

[BUG] Children are not cleaned from memory #1242

kamil-sienkiewicz-asi opened this issue Feb 28, 2025 · 2 comments

Comments

@kamil-sienkiewicz-asi
Copy link

Bug description
When tooltip is rendered with react children, it's not cleaning up rendered children and they remain in the memory

Version of Package
v5.28.0

To Reproduce
https://react-tooltip.com/docs/examples/children

Hover over example and see DOM nodes in dev tools rising

Expected behavior
Children is correctly cleaned up

Screenshots

Kapture.2025-02-28.at.17.36.14.webm

Desktop

  • OS: mac
  • Browser: chrome
  • Version: 133.0.6943.142
@danielbarion
Copy link
Member

Hi @kamil-sienkiewicz-asi, I'm sorry for the delay!

thanks for reporting and for the recording video, I'll be taking a look as soon as possible

@danielbarion danielbarion self-assigned this Mar 6, 2025
@danielbarion
Copy link
Member

I took a look in the master branch and also in the e v6 branch, I've added a few extra cleanup code to prevent memory leak, but on my tests, looks like there's no relevant progress so far, so I'll add the help wanted label on this one, please feel free to help too if you have any available time.

@danielbarion danielbarion removed their assignment Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants