Allow ExCS admin to set starter project identifier

To achieve this, I've had to remove the explicit *overriding* of
`Project#identifier` in `Project::Create.build_project` when the user is
an Experience CS admin.

Note that the `Project#check_unique_not_null` check which is triggered
on a `before_validation` callback will generate an identifier if none is
set in `Project::Create.build_project`

Author: floehopper

app/controllers/api/projects_controller.rb

@@ -27,7 +27,7 @@ def show
     end
 
     def create
-      result = Project::Create.call(project_hash: project_params)
+      result = Project::Create.call(project_hash: project_params, current_user:)
 
       if result.success?
         @project = result[:project]

app/graphql/mutations/create_project.rb

@@ -13,7 +13,7 @@ def resolve(**input)
         components: input[:components]&.map(&:to_h)
       )
 
-      response = Project::Create.call(project_hash:)
+      response = Project::Create.call(project_hash:, current_user: context[:current_user])
       raise GraphQL::ExecutionError, response[:error] unless response.success?
 
       { project: response[:project] }

lib/concepts/project/operations/create.rb

@@ -3,9 +3,9 @@
 class Project
   class Create
     class << self
-      def call(project_hash:)
+      def call(project_hash:, current_user:)
         response = OperationResponse.new
-        response[:project] = build_project(project_hash)
+        response[:project] = build_project(project_hash, current_user)
         response[:project].save!
         response
       rescue StandardError => e
@@ -16,9 +16,9 @@ def call(project_hash:)
 
       private
 
-      def build_project(project_hash)
-        identifier = PhraseIdentifier.generate
-        new_project = Project.new(project_hash.except(:components).merge(identifier:))
+      def build_project(project_hash, current_user)
+        project_hash[:identifier] = PhraseIdentifier.generate unless current_user&.experience_cs_admin?
+        new_project = Project.new(project_hash.except(:components))
         new_project.components.build(project_hash[:components])
         new_project
       end

spec/concepts/project/create_spec.rb

@@ -3,9 +3,10 @@
 require 'rails_helper'
 
 RSpec.describe Project::Create, type: :unit do
-  subject(:create_project) { described_class.call(project_hash:) }
+  subject(:create_project) { described_class.call(project_hash:, current_user:) }
 
-  let(:user_id) { 'e0675b6c-dc48-4cd6-8c04-0f7ac05af51a' }
+  let(:current_user) { create(:user) }
+  let(:user_id) { current_user.id }
 
   before do
     mock_phrase_generation
@@ -16,7 +17,7 @@
     let(:project_hash) { ActionController::Parameters.new({}).merge(user_id:) }
 
     context 'with valid content' do
-      subject(:create_project_with_content) { described_class.call(project_hash:) }
+      subject(:create_project_with_content) { described_class.call(project_hash:, current_user:) }
 
       let(:project_hash) do
         {

spec/features/project/creating_a_project_spec.rb

@@ -29,8 +29,9 @@
     expect(response).to have_http_status(:created)
   end
 
-  it 'generates an identifier for the project' do
-    post('/api/projects', headers:, params:)
+  it 'generates an identifier for the project even if another identifier is specified' do
+    params_with_identifier = { project: { identifier: 'test-identifier', components: [] } }
+    post('/api/projects', headers:, params: params_with_identifier)
     data = JSON.parse(response.body, symbolize_names: true)
 
     expect(data[:identifier]).to eq(generated_identifier)
@@ -213,6 +214,7 @@
     let(:params) do
       {
         project: {
+          identifier: 'test-project',
           name: 'Test Project',
           locale: 'fr',
           project_type: Project::Types::SCRATCH,
@@ -230,6 +232,13 @@
       expect(response).to have_http_status(:created)
     end
 
+    it 'sets the project identifier to the specified (not the generated) value' do
+      post('/api/projects', headers:, params:)
+      data = JSON.parse(response.body, symbolize_names: true)
+
+      expect(data[:identifier]).to eq('test-project')
+    end
+
     it 'sets the project name to the specified value' do
       post('/api/projects', headers:, params:)
       data = JSON.parse(response.body, symbolize_names: true)