You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having a look through UVData.read_cst_beam I get the impression it could be MUCH simplified. Some things I noticed:
There is a discrepancy between some of the keywords to the function, and the keys expected in the YAML file (eg. "frequency/frequencies" and "reference_impedance/ref_imp").
Exactly the same huge set of parameters is used, copy-pasted 3 times in the function. At the very least, these should be packed up into a dict and unpacked on each call.
There's a bunch of weird handling of over-riding YAML inputs with direct inputs to the function. I think it's debatable whether this should be allowed at all (isn't that allowing bad practice?), but if we do allow it, it would be much much easier to take in the parameters of the function as an explicit dictionary, and just do a dict update (point 1 would have to be fixed, of course). This would remove at least 3 repetitions of naming every single parameter that I can see.
The text was updated successfully, but these errors were encountered:
Having a look through
UVData.read_cst_beam
I get the impression it could be MUCH simplified. Some things I noticed:The text was updated successfully, but these errors were encountered: