Localization not passed in to ResolveLink

[tgfl-tom]

The localization parameter is not always passed into ResolveLink even when it is available.

Our project utilises the DD4T REST provider, which requires that the publication/localization is available.

I have created a pull request (#11) with a fix

[rpannekoek]

Sorry for the late response; we were quite busy with getting a DXA 1.3 release out lately.
Although I agree it makes sense to pass down a Localization object (just because we can), I was wondering: couldn't you use the Localization/Publication ID which is part of the TCM URI?

[rpannekoek]

Since DXA 2.0, link resolving is largely done in the DXA Model Service.
The Link Resolver is still used for a few use cases:

• Link resolving in (static) site maps
• Language Selector (PageController.Resolve)

Adding a Localization parameter to the ILinkResolver interface would be a compatibility break. Since the Publication ID is available in the TCM URI (and thus a Localization object can be retrieved if really needed), this does not justify a compatibility break.