-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[DM/PHYE] Support USB generic PHYE. #10997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-02 11:29 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a generic USB PHY driver to the RT-Thread phye subsystem, supporting USB PHY devices that follow the "usb-nop-xceiv" device tree binding. The driver provides basic PHY operations including reset control, power management, clock configuration, and voltage regulator support.
Key Changes:
- New generic USB PHY driver implementation with support for configurable reset pins, clocks, and regulators
- Build system integration via SConscript with RT_PHYE_GENERIC_USB configuration option
- Kconfig entry for enabling generic USB PHY support
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
components/drivers/phye/phye-generic-usb.c |
Implements generic USB PHY driver with probe/remove, power management, and reset operations |
components/drivers/phye/SConscript |
Adds conditional compilation for generic USB PHY driver |
components/drivers/phye/Kconfig |
Adds RT_PHYE_GENERIC_USB configuration option |
Signed-off-by: GuEe-GUI <[email protected]>
|
@Rbb666 AI 要求问题均解决 |
拉取/合并请求描述:(PR description)
[
Support USB generic PHYE
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up