Skip to content

[MM] Update MM System #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MM] Update MM System #10989

wants to merge 2 commits into from
+40 −8

Conversation

@GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Dec 1, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

  1. Support page MPR dynamic size for ([ARCH/RISC-V] Next RISC-V #10320)
  2. Fixup some LOG_D args.
  3. Stop installing page when rt_aspace_map_phy fail.

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@GuEe-GUI
[MM] Fixup MM
bd2f06e 
1. Fixup some LOG_D args.
2. Stop installing page when `rt_aspace_map_phy` fail.

Signed-off-by: GuEe-GUI <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：mm
  • 设置PR number为 \ Set the PR number to：10989
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 mm 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the mm branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/mm/Kconfig
  • components/mm/mm_aspace.c
  • components/mm/mm_memblock.c
  • components/mm/mm_page.c
  • components/mm/mm_page.h

📊 Current Review Status (Last Updated: 2025-12-02 12:10 CST)

  • ⌛ Maihuanyi Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666 Rbb666 requested a review from Copilot December 2, 2025 02:03
Copilot finished reviewing on behalf of Rbb666 December 2, 2025 02:06
Copilot AI reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the RT-Thread MM (Memory Management) system with three main improvements: adding support for dynamic page MPR (Memory Page Region) size, fixing LOG_D argument mismatches, and preventing page installation when physical address mapping fails.

Key Changes

  • Dynamic MPR Size Support: Introduces RT_PAGE_MPR_SIZE_DYNAMIC configuration option to support platforms where virtual address width is determined at runtime rather than compile-time
  • Bug Fixes: Corrects several LOG_D format string arguments that referenced undefined variables and fixes a macro parameter name mismatch
  • Error Handling: Adds a check to skip page installation when rt_aspace_map_phy fails, preventing potential system issues

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
components/mm/Kconfig Adds new RT_PAGE_MPR_SIZE_DYNAMIC configuration option for platforms with runtime-determined virtual address width
components/mm/mm_page.h Implements conditional compilation for dynamic vs static MPR size, defining rt_mpr_size_dynamic() function when dynamic mode is enabled
components/mm/mm_page.c Refactors MPR_SIZE calculation into a macro and implements rt_mpr_size_dynamic() function; fixes LOG_D argument using undefined page_nr variable
components/mm/mm_memblock.c Fixes LOG_D arguments using undefined variables (base, size, flag → start, end, flags); adds error checking to skip page installation on mapping failure
components/mm/mm_aspace.c Fixes macro _IS_OVERSIZE to use correct parameter names (limit_s, limit_sz instead of limit_start, limit_size)

@GuEe-GUI
[MM] Support page MPR dynamic size
c2ecae8 
For RISC-V or dynamic address space arch in the future.

Signed-off-by: GuEe-GUI <[email protected]>
@GuEe-GUI
Copy link
Contributor Author

GuEe-GUI commented Dec 2, 2025

@Rbb666 AI 相关问题已修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@BernardXiong BernardXiong Awaiting requested review from BernardXiong BernardXiong is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GuEe-GUI