Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Automatically commit changes to token property type names. #5189

Open
kwvanderlinde opened this issue Feb 7, 2025 · 1 comment
Labels
feature Adding functionality that adds value

Comments

@kwvanderlinde
Copy link
Collaborator

kwvanderlinde commented Feb 7, 2025

Describe the Problem

In the Token Property tab of the Campaign Properties dialog, it is possible to modify all the properties of the type and they will be committed when the dialog's OK button is pressed. The only exception is the type name. For this, there is no visible way to make the change stick - in fact, it requires pressing the Enter key while the field is focused, at which point a warning is presented to the user. Only once that warning is confirmed will the name change be committed with the rest of the dialog.

The Solution you'd like

I would like changes to the "Name:" field to be committed when the dialog's OK button is pressed.

Alternatives that you've considered.

  1. Add a "Rename" button to enable editing the name, showing the warning before the edit, but then allowing the modification to be committed without further input.
  2. Add a "Rename" button to submit the name. This would be functionally the same as today, but would be done through a visual element rather than requiring knowledge of needed to press Enter.

Additional Context

The only reason for handling name changes differently is because tokens store the name of the property type that they use. So when a name is changed, we have to go through all zones to find all tokens and modify them to use the new name. It could be worth changing property types to be referenced by GUID instead, so that names can be changed without requiring token modifications.

@kwvanderlinde kwvanderlinde added the feature Adding functionality that adds value label Feb 7, 2025
@FullBleed
Copy link

This would be a nice update as renaming Property Types is a "hidden" feature as is.

Some other improvements to the Campaign Properties Window:

  1. Not have to click out of a field to get some changes to stick.
  2. Save changes when closing the window automatically (unless you hit "Cancel").
  3. Rename the "OK" button to "Apply". That's a more accurate description of what it does.
  4. "Token Type" is the wrong naming convention. It should be "Property Type". (And there is an extraneous "Token Type" text line in the Token Properties tab.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

No branches or pull requests

2 participants