Additional warning when reading FCS3.2 files #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Will you be able to provide a dummy example fcs 3.2 file to be added to the package unit test? |
Contributor
Author
|
Hi, with the help of Issue#277 I was able to create a dummy fcs 3.2 file. I was not sure where to add it so I have added it to the following path: inst/extdata/S8_mliver.fcs. Hopefully this helps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCS3.2 files are not yet fully supported by flowCore.
As this might take some time to get resolved, we propose an additional warning. The main difference in FCS3.2 that is not yet supported is the allowance of specific data types for specific columns. Therefore, this error will list all columns which do not match the main datatype of the FCS file.
We think this will be helpful for everyone reading FCS3.2 files, and will have no impact at all on everyone else.