Skip to content

Commit 169b2d8

Browse files
fix: split CI into quality + test jobs to fix format check
Root cause: the test matrix removes pnpm-lock.yaml so different PMs can install deps. Without the lockfile, vite-plus resolves to a newer version with different oxfmt rules, causing vp check to fail on package.json formatting. Fix: quality job (format, lint, typecheck) runs once with the lockfile intact for deterministic deps. Test job runs the full OS/runtime/PM matrix without format checking.
1 parent 8e0b8de commit 169b2d8

File tree

2 files changed

+24
-7
lines changed

2 files changed

+24
-7
lines changed

.github/workflows/ci.yml

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,28 @@ concurrency:
1111
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
1212

1313
jobs:
14+
quality:
15+
name: Quality checks
16+
runs-on: ubuntu-latest
17+
steps:
18+
- uses: actions/checkout@v4
19+
20+
- uses: pnpm/action-setup@v4
21+
22+
- uses: voidzero-dev/setup-vp@v1
23+
with:
24+
node-version: "24"
25+
cache: true
26+
27+
- name: Format check
28+
run: vp check
29+
30+
- name: Lint
31+
run: vp lint
32+
33+
- name: Type check
34+
run: npx tsc --noEmit
35+
1436
test:
1537
name: Test on ${{ matrix.runtime }} / ${{ matrix.os }} / ${{ matrix.pm }}
1638
runs-on: ${{ matrix.os }}
@@ -43,12 +65,6 @@ jobs:
4365
node-version: "24"
4466
cache: true
4567

46-
- name: Lint
47-
run: vp lint
48-
49-
- name: Type check
50-
run: npx tsc --noEmit
51-
5268
- name: Build
5369
run: vp pack
5470

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,6 @@
5353
},
5454
"engines": {
5555
"node": ">=24.0.0"
56-
}
56+
},
57+
"packageManager": "pnpm@10.25.0"
5758
}

0 commit comments

Comments
 (0)