Automated code cleanup

Author: donatj

src/DotNotationParser.php

@@ -12,14 +12,13 @@
 class DotNotationParser {
 
 	/**
-	 * @param string $path
 	 * @return string[]
 	 */
 	public function parse( string $path ) : array {
 		$out   = [];
 		$chars = preg_split('/(?<!^)(?!$)/u', $path, -1, PREG_SPLIT_NO_EMPTY) ?: [];
 
-		for( ; ; ) {
+		for(;;) {
 			$token = current($chars);
 			if( $token === false ) {
 				break;
@@ -49,7 +48,7 @@ public function parse( string $path ) : array {
 	 */
 	private function scanString( array &$chars ) : string {
 		$buff = '';
-		for( ; ; ) {
+		for(;;) {
 			$token = current($chars);
 			if( $token === false || $token === '.' ) {
 				next($chars);
@@ -71,7 +70,7 @@ private function scanQuotedString( array &$chars ) : string {
 		$buff = '';
 
 		next($chars);
-		for( ; ; ) {
+		for(;;) {
 			$token = current($chars);
 			if( $token === false ) {
 				throw new ParseException(
@@ -80,6 +79,7 @@ private function scanQuotedString( array &$chars ) : string {
 					ParseException::CODE_UNEXPECTED_EOF
 				);
 			}
+
 			if( $token === '"' ) {
 				$next = next($chars);
 				if( $next === false || $next === '.' ) {

src/Exceptions/ParseException.php

@@ -9,7 +9,7 @@ class ParseException extends \InvalidArgumentException {
 
 	private $charIndex;
 
-	public function __construct( $message, int $charIndex, $code, \Throwable $previous = null ) {
+	public function __construct( $message, int $charIndex, $code, ?\Throwable $previous = null ) {
 		parent::__construct($message, $code, $previous);
 
 		$this->charIndex = $charIndex;

test/Quorum/DotNotation/DotNotationParserTest.php

@@ -9,7 +9,6 @@ class DotNotationParserTest extends TestCase {
 
 	/**
 	 * @dataProvider parseProvider
-	 * @param string   $path
 	 * @param string[] $result
 	 */
 	public function testParse( string $path, array $result ) : void {
@@ -23,9 +22,13 @@ public function testParse( string $path, array $result ) : void {
 
 	public function parseProvider() : \Generator {
 		yield [ 'foo.bar.baz', [ 'foo', 'bar', 'baz' ] ];
+
 		yield [ 'foo."bar.baz"', [ 'foo', 'bar.baz' ] ];
+
 		yield [ 'foo.bar"baz".2', [ 'foo', 'bar"baz"', '2' ] ];
+
 		yield [ 'foo.bar.baz.', [ 'foo', 'bar', 'baz' ] ];
+
 		yield [ '日.本.語', [ '日', '本', '語' ] ];
 	}
 
@@ -47,8 +50,12 @@ public function testUnexpectedCharacters( string $path, int $pos ) : void {
 
 	public function unexpectedCharacterProvider() : \Generator {
 		yield [ 'foo."bar', 8 ];
+
 		yield [ 'a.foo."bar"baz', 11 ];
+
 		yield [ '.foo', 0 ];
+
 		yield [ '.', 0 ];
 	}
+
 }