Skip to content

Commit 6e63b53

Browse files
authored
Merge pull request jupyter#438 from palewire/best-practices
Best practices fixes for Lighthouse
2 parents 3214ae2 + 894c4ec commit 6e63b53

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

_includes/footer.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<li><a href="{{site.baseurl}}/index.html">Home</a></li>
77
{%- for nav in site.data.nav.head %}
88
{%- if nav.url %}
9-
<li><a href="{{site.baseurl}}{{nav.url}}" target="_blank">{{nav.title}}</a></li>
9+
<li><a href="{{site.baseurl}}{{nav.url}}" target="_blank" rel="noopener noreferrer">{{nav.title}}</a></li>
1010
{%- else %}
1111
{%- for target_page in site.pages %}
1212
{%- if nav contains target_page.title %}

_includes/header.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
{%- if nav.url %}
2828
<li>
2929
{%- if nav.newpage %}
30-
<a href="{{site.baseurl}}{{nav.url}}" class="tab" target="_blank">{{nav.title}}</a>
30+
<a href="{{site.baseurl}}{{nav.url}}" class="tab" target="_blank" rel="noopener noreferrer">{{nav.title}}</a>
3131
{%- else %}
3232
<a href="{{site.baseurl}}{{nav.url}}" class="tab">{{nav.title}}</a>
3333
{%- endif %}

0 commit comments

Comments
 (0)