Remove unnecessary startActivityForResult calls

Author: equeim

src/main/java/org/quantumbadger/redreader/activities/MainActivity.java

@@ -574,7 +574,7 @@ public void onSelected(final PostListingURL url) {
 		} else {
 			final Intent intent = new Intent(this, PostListingActivity.class);
 			intent.setData(url.generateJsonUri());
-			startActivityForResult(intent, 1);
+			startActivity(intent);
 		}
 	}
 

src/main/java/org/quantumbadger/redreader/activities/OptionsMenuUtility.java

@@ -630,9 +630,7 @@ private static void add(
 							final Intent intent = new Intent(
 									activity,
 									SettingsActivity.class);
-							activity.startActivityForResult(
-									intent,
-									1);
+							activity.startActivity(intent);
 							return true;
 						});
 

src/main/java/org/quantumbadger/redreader/activities/PostListingActivity.java

@@ -417,7 +417,7 @@ public void onSidebar() {
 			intent.putExtra("title", String.format(Locale.US, "%s: %s",
 					getString(R.string.sidebar_activity_title),
 					fragment.getSubreddit().url));
-			startActivityForResult(intent, 1);
+			startActivity(intent);
 		}
 	}
 

src/main/java/org/quantumbadger/redreader/common/LinkHandler.kt

@@ -196,7 +196,7 @@ object LinkHandler {
 				RedditURLParser.SUBREDDIT_POST_LISTING_URL, RedditURLParser.MULTIREDDIT_POST_LISTING_URL, RedditURLParser.USER_POST_LISTING_URL, RedditURLParser.SEARCH_POST_LISTING_URL, RedditURLParser.UNKNOWN_POST_LISTING_URL -> {
 					val intent = Intent(activity, PostListingActivity::class.java)
 					intent.setData(redditURL.generateJsonUri())
-					activity.startActivityForResult(intent, 1)
+					activity.startActivity(intent)
 					return
 				}
 
@@ -206,7 +206,7 @@ object LinkHandler {
 						CommentListingActivity::class.java
 					)
 					intent.setData(redditURL.generateJsonUri())
-					activity.startActivityForResult(intent, 1)
+					activity.startActivity(intent)
 					return
 				}
 
@@ -227,7 +227,7 @@ object LinkHandler {
 						intent.putExtra(PMSendActivity.EXTRA_TEXT, cmUrl.message)
 					}
 
-					activity.startActivityForResult(intent, 1)
+					activity.startActivity(intent)
 					return
 				}
 

src/main/java/org/quantumbadger/redreader/fragments/RRFragment.java

@@ -60,12 +60,6 @@ protected final void startActivity(final Intent intent) {
 		mParent.startActivity(intent);
 	}
 
-	protected final void startActivityForResult(
-			final Intent intent,
-			final int requestCode) {
-		mParent.startActivityForResult(intent, requestCode);
-	}
-
 	public void onCreateOptionsMenu(final Menu menu) {
 	}
 

src/main/java/org/quantumbadger/redreader/reddit/SubredditDetails.java

@@ -93,6 +93,6 @@ public void showSidebarActivity(final AppCompatActivity context) {
 				context.getString(R.string.sidebar_activity_title),
 				url));
 
-		context.startActivityForResult(intent, 1);
+		context.startActivity(intent);
 	}
 }

src/main/java/org/quantumbadger/redreader/reddit/api/RedditPostActions.kt

@@ -481,7 +481,7 @@ object RedditPostActions {
 					val intent = Intent(activity, PostListingActivity::class.java)
 					intent.data = SubredditPostListURL.getSubreddit(post.src.subreddit)
 						.generateJsonUri()
-					activity.startActivityForResult(intent, 1)
+					activity.startActivity(intent)
 				} catch (e: InvalidSubredditNameException) {
 					Toast.makeText(
 						activity,

src/main/java/org/quantumbadger/redreader/reddit/things/RedditSubreddit.java

@@ -252,7 +252,7 @@ public void showSidebarActivity(final AppCompatActivity context) {
 				context.getString(R.string.sidebar_activity_title),
 				url));
 
-		context.startActivityForResult(intent, 1);
+		context.startActivity(intent);
 	}
 
 	@NonNull