Skip to content

Default to American English #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtpio opened this issue Sep 3, 2024 · 6 comments
Closed

Default to American English #145

jtpio opened this issue Sep 3, 2024 · 6 comments

Comments

@jtpio
Copy link
Member

jtpio commented Sep 3, 2024

For consistency across the website, it would be nice to default to American English.

Currently, there might be some inconsistencies, for example:

https://quantstack.net/projects/

image

https://quantstack.net/

image

@HaudinFlorence
Copy link
Member

HaudinFlorence commented Nov 15, 2024

It seems that PRs #147 and #152 have addressed this issue.
@jtpio @arjxn-py Could you please confirm me that this is ok ?

@HaudinFlorence
Copy link
Member

I can still see an UK english occurrence of organises somewhere. Does it mean that there is an issue with the pre-commit-hook ? Thanks

@arjxn-py
Copy link
Member

Hi @HaudinFlorence

It seems that PRs #147 and #152 have addressed this issue.

Yes, these PRs have addressed this issue

I can still see an UK english occurrence of organises somewhere. Does it mean that there is an issue with the pre-commit-hook ? Thanks

This is because the pre-commit hook auto update has been set to monthly and this specific occurrence has been added last week, we can either wait for the auto-update or can manually trigger it too. We can also increase the frequency of pre-commit auto-update from monthly to weekly, if we want.

@HaudinFlorence
Copy link
Member

HaudinFlorence commented Nov 15, 2024

Hi Arjun @arjxn-py Thanks for the precisions.
Maybe yes a weekly occurence may be better. Thanks a lot.

@arjxn-py
Copy link
Member

Maybe yes a weekly occurrence may be better.

Done in #177, thanks for the quick response :)

@HaudinFlorence
Copy link
Member

@arjxn-py Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants