Skip to content

Commit c982f1e

Browse files
HaudinFlorenceSylvainCorlay
authored andcommitted
Address style issue comments on the PR.
1 parent 23fe8b0 commit c982f1e

19 files changed

+10681
-213
lines changed

src/components/about/Avatar.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ export default function Avatar({ person }) {
1212
"working at QuantStack as a " +
1313
person.position
1414
}
15-
width={"300px"}
16-
height={"300px"}
1715
/>
1816
</div>
1917
);

src/components/about/SmallPortraitCard.tsx

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,31 @@ export function SmallPortraitCard({ person, setOffsets }) {
4343
return (
4444
<div
4545
ref={elementRef}
46-
className={styles.small_portrait_card}
46+
className={"card" + " " + styles.small_portrait_card}
4747
id={person.firstName}
4848
onClick={() => {
4949
setOffsets(calculateOffsets(elementRef));
5050
}}
5151
>
52-
<Avatar person={person} />
53-
<div className={"flex-full-centered" + " " + styles.small_card_complete_name}>
54-
{person.completeName}
52+
<div className="card__header">
53+
<Avatar person={person} />
54+
<div
55+
className={
56+
"flex-full-centered" + " " + styles.small_card_complete_name
57+
}
58+
>
59+
{person.completeName}
60+
</div>
5561
</div>
56-
<div className={"flex-full-centered" + " " + styles.small_card_position}>{person.position}</div>
57-
<div style={{ marginTop: "var(--ifm-spacing-xl)" }}>
58-
<SocialMediaContacts person={person}></SocialMediaContacts>
62+
<div className="card__body">
63+
<div
64+
className={"flex-full-centered" + " " + styles.small_card_position}
65+
>
66+
{person.position}
67+
</div>
68+
<div style={{ marginTop: "var(--ifm-spacing-xl)" }}>
69+
<SocialMediaContacts person={person}></SocialMediaContacts>
70+
</div>
5971
</div>
6072
</div>
6173
);

src/components/about/Team/coreTeam.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export const coreTeam = [
167167
githubLink: "https://github.com/ihuicatl",
168168
LinkedInLink: "https://www.linkedin.com/in/isabel-paredes/",
169169
XLink: "",
170-
githubName: "@ihuicatl",
170+
githubName: "@IsabelParedes",
171171
avatarUrl: IsabelAvatarUrl,
172172
distinctionTitle: [],
173173
distinctionLink: [],
@@ -253,7 +253,7 @@ export const coreTeam = [
253253
LinkedInLink: "https://www.linkedin.com/in/gjmooney/",
254254
XLink: "",
255255
githubName: "@gjmooney",
256-
avatarUrl: GabrielaAvatarUrl,
256+
avatarUrl: GregAvatarUrl,
257257
distinctionTitle: [],
258258
distinctionLink: [],
259259
subTeamName: "coreTeam",

src/components/about/styles.module.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ div .row {
5555
line-height: 24px;
5656
letter-spacing: 0.5px;
5757
color: var(--ifm-color-primary-p2);
58+
height: 2em;
59+
text-align: center;
5860
}
5961

6062
.large_card_complete_name {
@@ -139,7 +141,7 @@ div .join_the_team_text {
139141
font-family: var(--ifm-font-family-rubik-one);
140142
font-size: 20px;
141143
font-style: normal;
142-
font-weight: 600;
144+
font-weight: 400;
143145
line-height: 20px;
144146
text-align: center;
145147
margin-bottom: var(--ifm-spacing-xl);
@@ -190,7 +192,7 @@ div .join_the_team_text {
190192
font-family: var(--ifm-font-family-rubik-one);
191193
font-size: var(--ifm-font-size-secondary-title);
192194
font-style: normal;
193-
font-weight: 600;
195+
font-weight: 400;
194196
line-height: 28px;
195197
text-align: center;
196198
margin-bottom: var(--ifm-spacing-xl);

src/components/about/test.tsx

Whitespace-only changes.

0 commit comments

Comments
 (0)