Add 1D profile support (#108)

Author: martinRenou

gluepyter/glue_session.py

@@ -279,6 +279,16 @@ def _viewer_factory(
                         pass
             except Exception as e:
                 widget = ErrorWidget(e, __file__)
+        elif view_type == "glue.viewers.profile.state.ProfileLayerState":
+            try:
+                widget = self.app.profile1d(data=viewer_data)
+                for key, value in viewer_state.items():
+                    try:
+                        setattr(widget.state, key, value)
+                    except Exception:
+                        pass
+            except Exception as e:
+                widget = ErrorWidget(e, __file__)
 
         return widget
 

src/commands.ts

@@ -6,6 +6,8 @@ export namespace CommandIDs {
 
   export const new1DHistogram = 'glue-control:new-1d-histogram-viewer';
 
+  export const new1DProfile = 'glue-control:new-1d-profile-viewer';
+
   export const new2DImage = 'glue-control:new-2d-image-viewer';
 
   export const new2DScatter = 'glue-control:new-2d-scatter-viewer';

src/leftPanel/data/datasetsWidget.tsx

@@ -31,6 +31,7 @@ export class DatasetsWidget extends ReactWidget {
     viewerSubmenu.title.label = 'New Viewer';
     viewerSubmenu.title.iconClass = 'fa fa-caret-right';
     viewerSubmenu.addItem({ command: CommandIDs.new1DHistogram });
+    viewerSubmenu.addItem({ command: CommandIDs.new1DProfile });
     viewerSubmenu.addItem({ command: CommandIDs.new2DScatter });
     viewerSubmenu.addItem({ command: CommandIDs.new3DScatter });
     viewerSubmenu.addItem({ command: CommandIDs.new2DImage });

src/leftPanel/plugin.ts

@@ -51,6 +51,36 @@ function addCommands(
     }
   });
 
+  commands.addCommand(CommandIDs.new1DProfile, {
+    label: '1D Profile',
+    iconClass: 'fa fa-chart-line',
+    execute: (args?: INewViewerArgs) => {
+      if (!controlModel.sharedModel) {
+        return;
+      }
+
+      const tabs = Object.keys(controlModel.sharedModel.tabs);
+      const focusedTab = controlModel.sharedModel.getSelectedTab() || 1;
+      const layer = args?.dataset || controlModel.selectedDataset;
+
+      if (focusedTab === 0) {
+        return;
+      }
+
+      controlModel.sharedModel.setTabItem(tabs[focusedTab - 1], UUID.uuid4(), {
+        _type: 'glue.viewers.profile.state.ProfileLayerState',
+        pos: args?.position || [0, 0],
+        session: 'Session',
+        size: args?.size || [600, 400],
+        state: {
+          values: {
+            layer
+          }
+        }
+      });
+    }
+  });
+
   commands.addCommand(CommandIDs.new2DScatter, {
     label: '2D Scatter',
     iconClass: 'fa fa-chart-line',

src/schemas/viewers/1dprofile.schema.json

@@ -0,0 +1,42 @@
+{
+  "type": "object",
+  "description": "Viewer::Profile",
+  "title": "IGlueProfileViewer",
+  "required": ["_type", "layers", "pos", "session", "size", "state"],
+  "additionalProperties": false,
+  "properties": {
+    "_type": {
+      "const": "glue.viewers.profile.state.ProfileLayerState"
+    },
+    "layers": {
+      "type": "array",
+      "items": {
+        "type": "object"
+      }
+    },
+    "pos": {
+      "type": "array",
+      "items": {
+        "type": "number"
+      }
+    },
+    "session": {
+      "type": "string"
+    },
+    "size": {
+      "type": "array",
+      "items": {
+        "type": "number"
+      }
+    },
+    "state": {
+      "type": "object",
+      "additionalProperties": false,
+      "properties": {
+        "values": {
+          "type": "object"
+        }
+      }
+    }
+  }
+}

src/schemas/viewers/2dscatter.schema.json

@@ -1,7 +1,7 @@
 {
   "type": "object",
-  "description": "Viewer::Scatter",
-  "title": "IGlueScatterViewer",
+  "description": "Viewer::2DScatter",
+  "title": "IGlue2DScatterViewer",
   "required": ["_type", "layers", "pos", "session", "size", "state"],
   "additionalProperties": false,
   "properties": {

src/schemas/viewers/3dscatter.schema.json

@@ -1,7 +1,7 @@
 {
   "type": "object",
-  "description": "Viewer::Scatter",
-  "title": "IGlueScatterViewer",
+  "description": "Viewer::3DScatter",
+  "title": "IGlue3DScatterViewer",
   "required": ["_type", "layers", "pos", "session", "size", "state"],
   "additionalProperties": false,
   "properties": {

src/viewPanel/sessionWidget.ts

@@ -100,6 +100,7 @@ export class SessionWidget extends BoxPanel {
 
     const items: IDict<string> = {
       Histogram: CommandIDs.new1DHistogram,
+      '1D Profile': CommandIDs.new1DProfile,
       '2D Scatter': CommandIDs.new2DScatter,
       '3D Scatter': CommandIDs.new3DScatter,
       '2D Image': CommandIDs.new2DImage,