Skip to content

Commit 1430dee

Browse files
author
jiangxinglei
committed
remove comments
1 parent 4d44aa1 commit 1430dee

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

core/kernels/bn_table_ops.cc

+1-4
Original file line numberDiff line numberDiff line change
@@ -104,16 +104,13 @@ class BnStatisticsPushKernel : public AsyncOpKernel {
104104
double* dynamic_double_data = new double[num_elements];
105105
const float* float_data = var_tensor->flat<float>().data();
106106
for (int i = 0; i < num_elements; ++i) {
107-
// std::cout << "float data is: " << float_data[i] << std::endl;
108107
dynamic_double_data[i] = static_cast<double>(float_data[i]);
109-
// std::cout << "double data is: " << dynamic_double_data[i] << std::endl;
110108
}
111109
acc_buf.append_user_data(dynamic_double_data, num_elements * sizeof(double), NoOpDeleter);
112-
// acc_buf.append_user_data(var_tensor->flat<float>().data(), var_tensor->NumElements() * sizeof(float), NoOpDeleter);
113110
allocated_pointers.push_back(dynamic_double_data);
114111
}
115112

116-
BnTable* table = BnTableRegistry::Instance()->Get(table_handle_);
113+
BnTable* table = BnTableRegistry::Instance()->Get(table_handle_);
117114
table->Append(acc_buf, true);
118115

119116
for (auto ptr : allocated_pointers) {

core/ps/table/bn_table.cc

-3
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ void BnTable::Append(butil::IOBuf& bn_statistics_buf, bool isLocal) {
7373

7474
uint64_t cur_count = static_cast<uint64_t>(total_count_.maxCoeff());
7575

76-
// std::cout << "cur_count is : " << cur_count << std::endl;
77-
// PrintDetail();
78-
// std::cout << "acc_count is : " << acc_count(0) << std::endl;
7976
if(max_count_ > 0 && cur_count > max_count_) {
8077
uint64_t acc_count_num = static_cast<uint64_t>(acc_count.maxCoeff());
8178
double ratio = (double) acc_count_num / cur_count;

core/ps/table/bn_table.h

+3-4
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,10 @@ class BnTable {
7575
Eigen::ArrayXd total_squared_sum_;
7676
Eigen::ArrayXd total_squared_sum_err_;
7777
Eigen::ArrayXd total_count_;
78-
Eigen::ArrayXd inc_sum_;
79-
Eigen::ArrayXd inc_squared_sum_;
80-
Eigen::ArrayXd inc_count_;
78+
Eigen::ArrayXd inc_sum_;
79+
Eigen::ArrayXd inc_squared_sum_;
80+
Eigen::ArrayXd inc_count_;
8181
std::unique_ptr<std::mutex> mu_;
82-
8382
};
8483

8584
class BnTableRegistry {

0 commit comments

Comments
 (0)