Skip to content

Commit a24ec25

Browse files
authored
[MRG] Debug sinkhorn divergence bug and add proper test (#394)
* skip tets if not torch installed * update release.md
1 parent f2aaf40 commit a24ec25

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

RELEASES.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
#### Closed issues
1111

12+
- Fixed an issue where sinkhorn divergence did not have a gradients (Issue #393, PR #394)
1213
- Fixed an issue where we could not ask TorchBackend to place a random tensor on GPU
1314
(Issue #371, PR #373)
1415
- Fixed an issue where Sinkhorn solver assumed a symmetric cost matrix (Issue #374, PR #375)

test/test_bregman.py

+1
Original file line numberDiff line numberDiff line change
@@ -879,6 +879,7 @@ def test_empirical_sinkhorn_divergence(nx):
879879
ot.bregman.empirical_sinkhorn_divergence(X_sb, X_tb, 1, a=ab, b=bb, log=True)
880880

881881

882+
@pytest.mark.skipif(not torch, reason="No torch available")
882883
def test_empirical_sinkhorn_divergence_gradient():
883884
# Test sinkhorn divergence
884885
n = 10

0 commit comments

Comments
 (0)