Allow borrowed object for PyTuple::get_item.

davidhewitt · davidhewitt · commit 6f74fe6b38f9 · 2020-05-03T18:48:01.000+01:00
As per feedback on #890
diff --git a/src/types/tuple.rs b/src/types/tuple.rs
@@ -72,10 +72,8 @@ impl PyTuple {
     pub fn get_item(&self, index: usize) -> &PyAny {
         assert!(index < self.len());
         unsafe {
-            // PyTuple_GET_ITEM return borrowed ptr; must make owned for safety (see #890).
-            let ptr = ffi::PyTuple_GET_ITEM(self.as_ptr(), index as Py_ssize_t);
-            ffi::Py_INCREF(ptr);
-            self.py().from_owned_ptr(ptr)
+            self.py()
+                .from_borrowed_ptr(ffi::PyTuple_GET_ITEM(self.as_ptr(), index as Py_ssize_t))
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,8 @@ impl PyTuple {`
`72`	`72`	`pub fn get_item(&self, index: usize) -> &PyAny {`
`73`	`73`	`assert!(index < self.len());`
`74`	`74`	`unsafe {`
`75`		`- // PyTuple_GET_ITEM return borrowed ptr; must make owned for safety (see #890).`
`76`		`- let ptr = ffi::PyTuple_GET_ITEM(self.as_ptr(), index as Py_ssize_t);`
`77`		`- ffi::Py_INCREF(ptr);`
`78`		`- self.py().from_owned_ptr(ptr)`
	`75`	`+ self.py()`
	`76`	`+ .from_borrowed_ptr(ffi::PyTuple_GET_ITEM(self.as_ptr(), index as Py_ssize_t))`
`79`	`77`	`}`
`80`	`78`	`}`
`81`	`79`