Merge pull request #180 from PyAutoLabs/feature/hygiene-refs-dotdir

fix(hygiene): refs mangles dot-directory references

Author: Jammy2211

agents/conductors/hygiene/_hygiene_refs.py

@@ -361,9 +361,18 @@ def resolves(self, reference: str, repo: str, directory: str) -> bool | None:
         target = self.index(repo)
         if target is None:
             return None
-        path = reference.lstrip("./")
-        while path.startswith("../"):
-            path = path[3:]
+        # Strip leading `./` and `../` as *prefixes*. `lstrip("./")` would strip
+        # the character set, silently mangling every reference to a dot-directory
+        # (`.claude/skills` -> `claude/skills`, `.github/workflows` ->
+        # `github/workflows`) and then reporting it as dead.
+        path = reference
+        while True:
+            if path.startswith("../"):
+                path = path[3:]
+            elif path.startswith("./"):
+                path = path[2:]
+            else:
+                break
         head = path.split("/", 1)[0]
         if head in RUNTIME_DIRECTORIES:
             return None

tests/test_hygiene_conductor.py

@@ -633,6 +633,34 @@ def test_refs_suppresses_prose_slashes_and_absolute_paths(tmp_path):
     assert "imaging/modeling" not in found
 
 
+def test_refs_resolves_dot_directory_references(tmp_path):
+    workspace = tmp_path / "demo_workspace"
+    (workspace / "scripts").mkdir(parents=True)
+    (workspace / ".claude" / "skills").mkdir(parents=True)
+    # `.github/` exists but holds no `workflows/`, so the reference below is
+    # anchored (the guard will judge it) yet genuinely dead.
+    (workspace / ".github").mkdir()
+    (workspace / "README.md").write_text(
+        "\n".join(
+            [
+                "- `scripts`: example scripts.",
+                "See `.claude/skills` for agent skills and `.github/workflows` for CI.",
+                "",
+            ]
+        )
+    )
+
+    found = {f["reference"] for f in _refs_row(tmp_path)["findings"]}
+
+    # A leading dot must survive prefix-stripping. Before the fix, `lstrip("./")`
+    # ate it: `.claude/skills` became `claude/skills` and was reported dead even
+    # though it exists, and `.github/workflows` was reported under a mangled name.
+    assert ".claude/skills" not in found
+    assert ".github/workflows" in found
+    assert "github/workflows" not in found
+    assert "claude/skills" not in found
+
+
 def test_refs_findings_reach_the_default_worklist(tmp_path):
     _write_refs_fixture(tmp_path)