Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 18 #1276

Open
ddohler opened this issue Oct 21, 2022 · 0 comments
Open

Upgrade to React 18 #1276

ddohler opened this issue Oct 21, 2022 · 0 comments

Comments

@ddohler
Copy link
Collaborator

ddohler commented Oct 21, 2022

Detailed Description

We should upgrade to React v18.

Context

React 18 is the latest version of React. We are on v17.

Alternatives

N/A

Known issues

  • Currently, we are passing DISABLE_NEW_JSX_TRANSFORM=true to the client container because theme-ui v0.13 is not compatible with the new JSX transform introduced in React 17. theme-ui v0.14 adds compatibility with the new JSX transform, but upgrading to it introduced a bunch of type errors, despite the fact that no backwards-incompatible changes were listed in the release notes. theme-ui 0.15 adds React 18 compatibility, but drops compatibility with React 17 and below. However, it also introduces backwards-incompatible changes that affect the way we're using the library. So I think the best way to proceed is probably to re-enable the new JSX transform, and upgrade to React 18 and to theme-ui v0.15 in one step. Then we can address the backwards-incompatible changes in theme-ui v0.15 at that point; both the listed changes for v0.15 and the Typescript errors I was receiving relate to the use of Themed, so hopefully upgrading directly to v0.15 will allow us to just fix everything once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant