Made changes to browser details function

Author: pm-azhar-mulla

Diff for: src_new/adapters/prebid.js

@@ -1072,7 +1072,7 @@ function getFloorsConfiguration(prebidConfig){
 				url: CONFIG.getFloorJsonUrl()
 			},
 			additionalSchemaFields : {
-				browser : util.getBrowser,
+				browser : util.getBrowserDetails,
 				platform_id : util.getPltForFloor
 			}
 		}

Diff for: src_new/constants.js

@@ -317,7 +317,6 @@ exports.DEFAULT_ALIASES = {
 }
 exports.YAHOOSSP = "yahoossp";
 
-exports.listOfBrowsers = ["AmigaVoyager","Cyberdog","Dillo","Dooble","Enigma Browser","Galaxy","HotJava","IBM WebExplorer","Links","Lynx","NCSA_Mosaic","Skyfire","Obigo","Blazer","Blackberry","Blot","Iris","NetFront","Openwave","Skweezer","NetSurf","EudoraWeb","DoCoMo","PocketLink","Plucker","Xiino","Mobile Safari","Nintendo","retawq","uzbl","w3m","WorldWideWeb","ABrowse","Acoo Browser","Arora","Beonex","BonEcho","Camino","Charon","Cheshire","Chimera","ChromePlus","CometBird","Comodo_Dragon","Crazy Browser","Deepnet Explorer","DeskBrowse","Element Browser","Elinks","Escape","Fennec","Firebird","Flock","Fluid","Galeon","GranParadiso","GreenBrowser","Hana","IBrowse","IceCat","Iceape","Iceweasel","Iron","K-Meleon","K-Ninja","KKman","KMLite","Kapiko","Kazehakase","Konqueror","LeechCraft","Lobo","Lorentz","Lunascape","Madfox","Midori","Minefield","Minimo","Namoroka","NetNewsWire","NetPositive","Netscape","OmniWeb","Opera Mini","Opera Mobi","Orca","Oregano","Palemoon","Phoenix","Pogo","Prism","QtWeb Internet Browser","SeaMonkey","Shiira","Shiretoko","Sleipnir","SlimBrowser","Stainless","Sunrise","TeaShark","Vonkeror","Wyzo","iCab","iNet Browser","iRider","lolifox","myibrow","uZard Web","AOL","Avant Browser","Chrome","Epiphany","Maxthon","MultiZilla","MyIE2","Opera","Safari","Firefox","MSIE","Mozilla"]
 exports.REGEX_BROWSERS = [/\b(?:crmo|crios)\/([\w\.]+)/i,/edg(?:e|ios|a)?\/([\w\.]+)/i,/(opera mini)\/([-\w\.]+)/i,/(opera [mobiletab]{3,6})\b.+version\/([-\w\.]+)/i,/(opera)(?:.+version\/|[\/ ]+)([\w\.]+)/i,
 /opios[\/ ]+([\w\.]+)/i,/\bopr\/([\w\.]+)/i,/(kindle)\/([\w\.]+)/i,/(lunascape)[\/ ]?([\w\.]*)/i,/(maxthon)[\/ ]?([\w\.]*)/i,/(netfront)[\/ ]?([\w\.]*)/i,/(jasmine)[\/ ]?([\w\.]*)/i,/(blazer)[\/ ]?([\w\.]*)/i,
 /(avant |iemobile|slim)(?:browser)?[\/ ]?([\w\.]*)/i,/(ba?idubrowser)[\/ ]?([\w\.]+)/i,/(?:ms|\()(ie) ([\w\.]+)/i,/(flock)\/([-\w\.]+)/i,/(rockmelt)\/([-\w\.]+)/i,/(midori)\/([-\w\.]+)/i,/(epiphany)\/([-\w\.]+)/i,

Diff for: src_new/util.js

@@ -1936,17 +1936,8 @@ exports.applyCustomParamValuesfApplicable = function(params) {
 	}
 }
 
-exports.getBrowser = function() {
-	var userAgent = navigator.userAgent;
-	var browserName = userAgent == null ? "UNKNOWN" : "unknown";
-	var i;
-	for( i = 0; i < CONSTANTS.listOfBrowsers.length; i++ ) {
-		if(userAgent.includes(CONSTANTS.listOfBrowsers[i])) {
-			browserName = CONSTANTS.listOfBrowsers[i];
-			break;
-		}
-	}
-	return browserName;
+exports.getBrowserDetails = function() {
+	return bidManager.getBrowser().toString();
 }
 exports.getPltForFloor = function() {
 	return refThis.getDevicePlatform().toString();

Diff for: test/adapters/prebid.spec.js

@@ -952,7 +952,7 @@ describe('ADAPTER: Prebid', function() {
                     url: "externalFloor.json"
                 },
 				additionalSchemaFields : {
-					browser : UTIL.getBrowser,
+					browser : UTIL.getBrowserDetails,
 					platform_id : UTIL.getPltForFloor
 				}
             }

Diff for: test/util.spec.js

@@ -4035,5 +4035,16 @@ describe('UTIL', function() {
         });
     });  
 
-  
+    describe('#getBrowserDetails', function() {
+		it('is a function', function(done) {
+            UTIL.getBrowserDetails.should.be.a('function');
+            done();
+        });
+
+        it('should have return browser mapping value', function(done) {
+            var browserMapping = UTIL.getBrowserDetails();
+			expect(browserMapping).not.to.be.null;
+            done();
+        });
+	});
 });