Skip to content

Commit 5504571

Browse files
Handle case - Do not replace namespace if default namespaces are set in the config.
1 parent 483d4a2 commit 5504571

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

gulpfile.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -437,15 +437,15 @@ function addPattern(patterns, match, replacement) {
437437
}
438438

439439
function getPatternsToReplace() {
440-
const { COMMON } = require('./src_new/constants.js');
440+
const { COMMON, CONFIG } = require('./src_new/constants.js');
441441
var patterns = [];
442442
if (isIdentityOnly) {
443-
addPattern(patterns, /ihowpbjs|owpbjs/g, config.getPbGloabalVarNamespace(COMMON.IH_NAMESPACE));
444-
addPattern(patterns, /IHPWT/g, config.getOwGloabalVarNamespace(null));
443+
addPattern(patterns, /ihowpbjs|owpbjs/g, config.getOverrideNamespace(CONFIG.PB_GLOBAL_VAR_NAMESPACE, COMMON.IH_NAMESPACE, COMMON.IH_NAMESPACE));
444+
addPattern(patterns, /IHPWT/g, config.getOverrideNamespace(CONFIG.OW_GLOBAL_VAR_NAMESPACE, COMMON.IH_OW_NAMESPACE, null));
445445
} else {
446446
// Passing null as we don't want to replace the used value(i.e. PWT) with default value(i.e. PWT) as both are same,
447-
addPattern(patterns, /owpbjs/g, config.getPbGloabalVarNamespace(null));
448-
addPattern(patterns, /PWT/g, config.getOwGloabalVarNamespace(null));
447+
addPattern(patterns, /owpbjs/g, config.getOverrideNamespace(CONFIG.PB_GLOBAL_VAR_NAMESPACE, COMMON.PREBID_NAMESPACE, null));
448+
addPattern(patterns, /PWT/g, config.getOverrideNamespace(CONFIG.OW_GLOBAL_VAR_NAMESPACE, COMMON.OPENWRAP_NAMESPACE, null));
449449
}
450450
return patterns;
451451
}

src_new/config.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,13 @@ exports.getAwc = function () {
144144
return awc === "1";
145145
};
146146

147-
exports.getPbGloabalVarNamespace = function(defaultName) {
148-
return config[CONSTANTS.CONFIG.COMMON][CONSTANTS.CONFIG.PB_GLOBAL_VAR_NAMESPACE] || defaultName;
149-
}
150-
151-
exports.getOwGloabalVarNamespace = function(defaultName) {
152-
return config[CONSTANTS.CONFIG.COMMON][CONSTANTS.CONFIG.OW_GLOBAL_VAR_NAMESPACE] || defaultName;
147+
exports.getOverrideNamespace = function(configKey, defaultName, returnValueInCaseMissingNamespace) {
148+
var pbNamespace = config[CONSTANTS.CONFIG.COMMON][configKey];
149+
if (pbNamespace) {
150+
return pbNamespace === defaultName ? returnValueInCaseMissingNamespace : pbNamespace;
151+
} else {
152+
return returnValueInCaseMissingNamespace;
153+
}
153154
}
154155

155156
/* start-test-block */

src_new/constants.js

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ exports.COMMON = {
2525
"AD_SERVER_CURRENCY": "adServerCurrency",
2626
"SINGLE_IMPRESSION": "singleImpression",
2727
"OPENWRAP_NAMESPACE": "PWT",
28+
"IH_OW_NAMESPACE": "IHPWT",
2829
"PREBID_NAMESPACE": "owpbjs",
2930
"IH_NAMESPACE": "ihowpbjs",
3031
"ENABLE_USER_ID": "identityEnabled",

0 commit comments

Comments
 (0)