Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] Avoid checking certificate signatures twice. #3558

Open
acoglio opened this issue Mar 27, 2025 · 0 comments
Open

[Optimization] Avoid checking certificate signatures twice. #3558

acoglio opened this issue Mar 27, 2025 · 0 comments
Labels
feature New feature or request

Comments

@acoglio
Copy link
Contributor

acoglio commented Mar 27, 2025

As a validator collects endorsing signatures from other validators, it verifies them. When it has enough signatures, it creates a certificate with BatchCertificate::from(), which verifies the signatures again. We can avoid this duplication by having the validator call BatchCertificate::from_unchecked() instead. BatchCertificate::from() performs a few other simple checks besides verifying signatures; these other simple checks are easy for the validator to perform before calling BatchCertificate::from_unchecked().

@acoglio acoglio added the feature New feature or request label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant