Skip to content

Commit d04966a

Browse files
Chavi WeingartenAndroid (Google) Code Review
authored andcommitted
Merge "Fix implicit cast from ssize_t to size_t in KeyedVector.h" into sc-dev
2 parents 229c465 + 51b958d commit d04966a

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

libutils/include/utils/KeyedVector.h

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class KeyedVector
4747

4848
inline void clear() { mVector.clear(); }
4949

50-
/*!
50+
/*!
5151
* vector stats
5252
*/
5353

@@ -63,14 +63,14 @@ class KeyedVector
6363
// returns true if the arguments is known to be identical to this vector
6464
inline bool isIdenticalTo(const KeyedVector& rhs) const;
6565

66-
/*!
66+
/*!
6767
* accessors
6868
*/
69-
const VALUE& valueFor(const KEY& key) const;
70-
const VALUE& valueAt(size_t index) const;
71-
const KEY& keyAt(size_t index) const;
72-
ssize_t indexOfKey(const KEY& key) const;
73-
const VALUE& operator[] (size_t index) const;
69+
const VALUE& valueFor(const KEY& key) const;
70+
const VALUE& valueAt(size_t index) const;
71+
const KEY& keyAt(size_t index) const;
72+
ssize_t indexOfKey(const KEY& key) const;
73+
const VALUE& operator[](size_t index) const;
7474

7575
/*!
7676
* modifying the array
@@ -79,10 +79,10 @@ class KeyedVector
7979
VALUE& editValueFor(const KEY& key);
8080
VALUE& editValueAt(size_t index);
8181

82-
/*!
82+
/*!
8383
* add/insert/replace items
8484
*/
85-
85+
8686
ssize_t add(const KEY& key, const VALUE& item);
8787
ssize_t replaceValueFor(const KEY& key, const VALUE& item);
8888
ssize_t replaceValueAt(size_t index, const VALUE& item);
@@ -93,7 +93,7 @@ class KeyedVector
9393

9494
ssize_t removeItem(const KEY& key);
9595
ssize_t removeItemsAt(size_t index, size_t count = 1);
96-
96+
9797
private:
9898
SortedVector< key_value_pair_t<KEY, VALUE> > mVector;
9999
};
@@ -208,7 +208,7 @@ DefaultKeyedVector<KEY,VALUE>::DefaultKeyedVector(const VALUE& defValue)
208208
template<typename KEY, typename VALUE> inline
209209
const VALUE& DefaultKeyedVector<KEY,VALUE>::valueFor(const KEY& key) const {
210210
ssize_t i = this->indexOfKey(key);
211-
return i >= 0 ? KeyedVector<KEY,VALUE>::valueAt(i) : mDefault;
211+
return i >= 0 ? KeyedVector<KEY, VALUE>::valueAt(static_cast<size_t>(i)) : mDefault;
212212
}
213213

214214
} // namespace android

0 commit comments

Comments
 (0)