Skip to content

Commit 9e987cb

Browse files
committed
Note selinux trans error happens in permissive.
There was an email thread about this recently, and I've been asked many times. For instance, if this error wasn't attributed, denials a service is hitting would be attributed to init, and that's a recipe for disaster. Secondarily, thinking about SELinux whenever you write a new service is good. Bug: N/A Test: N/A Change-Id: Ib9d2c5d8947375a0d4c33ecf3d075caef6b41f70
1 parent e1948bf commit 9e987cb

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

init/service.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ static Result<std::string> ComputeContextFromExecutable(const std::string& servi
9090
<< "\") has incorrect label or no domain transition from " << mycon.get()
9191
<< " to another SELinux domain defined. Have you configured your "
9292
"service correctly? https://source.android.com/security/selinux/"
93-
"device-policy#label_new_services_and_address_denials";
93+
"device-policy#label_new_services_and_address_denials. Note: this "
94+
"error shows up even in permissive mode in order to make auditing "
95+
"denials possible.";
9496
}
9597
if (rc < 0) {
9698
return Error() << "Could not get process context";

0 commit comments

Comments
 (0)