Skip to content

Commit 3f67fb8

Browse files
author
Tom Cherry
committed
init: fix todo in a test
Structured bindings with templated containers work now, so no need for the workaround or TODO. Test: init unit tests Change-Id: I6a286de9859d8a97df480a7ac2862a3a10bd9fb3
1 parent 7ef143f commit 3f67fb8

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

init/ueventd_test.cpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,7 @@ void WriteFromMultipleThreads(std::vector<std::pair<std::string, T>>& files_and_
5353
};
5454

5555
std::vector<std::thread> threads;
56-
// TODO(b/63712782): Structured bindings + templated containers are broken in clang :(
57-
// for (const auto& [file, parameter] : files_and_parameters) {
58-
for (const auto& pair : files_and_parameters) {
59-
const auto& file = pair.first;
60-
const auto& parameter = pair.second;
56+
for (const auto& [file, parameter] : files_and_parameters) {
6157
threads.emplace_back(std::thread(make_thread_function(file, parameter)));
6258
}
6359

0 commit comments

Comments
 (0)