Skip to content

Commit 1a955fa

Browse files
Treehugger RobotGerrit Code Review
authored andcommitted
Merge "Pass in message_version_ received from the secure side."
2 parents 44ad937 + 38b9b49 commit 1a955fa

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

trusty/keymaster/trusty_keymaster_device.cpp

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -177,14 +177,14 @@ keymaster_error_t TrustyKeymasterDevice::configure(const keymaster_key_param_set
177177
}
178178

179179
AuthorizationSet params_copy(*params);
180-
ConfigureRequest request;
180+
ConfigureRequest request(message_version_);
181181
if (!params_copy.GetTagValue(TAG_OS_VERSION, &request.os_version) ||
182182
!params_copy.GetTagValue(TAG_OS_PATCHLEVEL, &request.os_patchlevel)) {
183183
ALOGD("Configuration parameters must contain OS version and patch level");
184184
return KM_ERROR_INVALID_ARGUMENT;
185185
}
186186

187-
ConfigureResponse response;
187+
ConfigureResponse response(message_version_);
188188
keymaster_error_t err = Send(KM_CONFIGURE, request, &response);
189189
if (err != KM_ERROR_OK) {
190190
return err;
@@ -200,9 +200,9 @@ keymaster_error_t TrustyKeymasterDevice::add_rng_entropy(const uint8_t* data, si
200200
return error_;
201201
}
202202

203-
AddEntropyRequest request;
203+
AddEntropyRequest request(message_version_);
204204
request.random_data.Reinitialize(data, data_length);
205-
AddEntropyResponse response;
205+
AddEntropyResponse response(message_version_);
206206
return Send(KM_ADD_RNG_ENTROPY, request, &response);
207207
}
208208

@@ -261,11 +261,11 @@ keymaster_error_t TrustyKeymasterDevice::get_key_characteristics(
261261
return KM_ERROR_OUTPUT_PARAMETER_NULL;
262262
}
263263

264-
GetKeyCharacteristicsRequest request;
264+
GetKeyCharacteristicsRequest request(message_version_);
265265
request.SetKeyMaterial(*key_blob);
266266
AddClientAndAppData(client_id, app_data, &request);
267267

268-
GetKeyCharacteristicsResponse response;
268+
GetKeyCharacteristicsResponse response(message_version_);
269269
keymaster_error_t err = Send(KM_GET_KEY_CHARACTERISTICS, request, &response);
270270
if (err != KM_ERROR_OK) {
271271
return err;
@@ -379,7 +379,7 @@ keymaster_error_t TrustyKeymasterDevice::attest_key(const keymaster_key_blob_t*
379379
cert_chain->entry_count = 0;
380380
cert_chain->entries = nullptr;
381381

382-
AttestKeyRequest request;
382+
AttestKeyRequest request(message_version_);
383383
request.SetKeyMaterial(*key_to_attest);
384384
request.attest_params.Reinitialize(*attest_params);
385385

@@ -391,7 +391,7 @@ keymaster_error_t TrustyKeymasterDevice::attest_key(const keymaster_key_blob_t*
391391
return KM_ERROR_INVALID_INPUT_LENGTH;
392392
}
393393

394-
AttestKeyResponse response;
394+
AttestKeyResponse response(message_version_);
395395
keymaster_error_t err = Send(KM_ATTEST_KEY, request, &response);
396396
if (err != KM_ERROR_OK) {
397397
return err;
@@ -439,11 +439,11 @@ keymaster_error_t TrustyKeymasterDevice::upgrade_key(const keymaster_key_blob_t*
439439
return KM_ERROR_OUTPUT_PARAMETER_NULL;
440440
}
441441

442-
UpgradeKeyRequest request;
442+
UpgradeKeyRequest request(message_version_);
443443
request.SetKeyMaterial(*key_to_upgrade);
444444
request.upgrade_params.Reinitialize(*upgrade_params);
445445

446-
UpgradeKeyResponse response;
446+
UpgradeKeyResponse response(message_version_);
447447
keymaster_error_t err = Send(KM_UPGRADE_KEY, request, &response);
448448
if (err != KM_ERROR_OK) {
449449
return err;
@@ -480,12 +480,12 @@ keymaster_error_t TrustyKeymasterDevice::begin(keymaster_purpose_t purpose,
480480
*out_params = {};
481481
}
482482

483-
BeginOperationRequest request;
483+
BeginOperationRequest request(message_version_);
484484
request.purpose = purpose;
485485
request.SetKeyMaterial(*key);
486486
request.additional_params.Reinitialize(*in_params);
487487

488-
BeginOperationResponse response;
488+
BeginOperationResponse response(message_version_);
489489
keymaster_error_t err = Send(KM_BEGIN_OPERATION, request, &response);
490490
if (err != KM_ERROR_OK) {
491491
return err;
@@ -528,7 +528,7 @@ keymaster_error_t TrustyKeymasterDevice::update(keymaster_operation_handle_t ope
528528
*output = {};
529529
}
530530

531-
UpdateOperationRequest request;
531+
UpdateOperationRequest request(message_version_);
532532
request.op_handle = operation_handle;
533533
if (in_params) {
534534
request.additional_params.Reinitialize(*in_params);
@@ -538,7 +538,7 @@ keymaster_error_t TrustyKeymasterDevice::update(keymaster_operation_handle_t ope
538538
request.input.Reinitialize(input->data, std::min(input->data_length, max_input_size));
539539
}
540540

541-
UpdateOperationResponse response;
541+
UpdateOperationResponse response(message_version_);
542542
keymaster_error_t err = Send(KM_UPDATE_OPERATION, request, &response);
543543
if (err != KM_ERROR_OK) {
544544
return err;
@@ -589,7 +589,7 @@ keymaster_error_t TrustyKeymasterDevice::finish(keymaster_operation_handle_t ope
589589
*output = {};
590590
}
591591

592-
FinishOperationRequest request;
592+
FinishOperationRequest request(message_version_);
593593
request.op_handle = operation_handle;
594594
if (signature && signature->data && signature->data_length > 0) {
595595
request.signature.Reinitialize(signature->data, signature->data_length);
@@ -601,7 +601,7 @@ keymaster_error_t TrustyKeymasterDevice::finish(keymaster_operation_handle_t ope
601601
request.additional_params.Reinitialize(*in_params);
602602
}
603603

604-
FinishOperationResponse response;
604+
FinishOperationResponse response(message_version_);
605605
keymaster_error_t err = Send(KM_FINISH_OPERATION, request, &response);
606606
if (err != KM_ERROR_OK) {
607607
return err;
@@ -634,9 +634,9 @@ keymaster_error_t TrustyKeymasterDevice::abort(keymaster_operation_handle_t oper
634634
return error_;
635635
}
636636

637-
AbortOperationRequest request;
637+
AbortOperationRequest request(message_version_);
638638
request.op_handle = operation_handle;
639-
AbortOperationResponse response;
639+
AbortOperationResponse response(message_version_);
640640
return Send(KM_ABORT_OPERATION, request, &response);
641641
}
642642

0 commit comments

Comments
 (0)