Add logging when language client not defined.

Clean up TODO comments
Clean up request type naming.
White space cleanup

Author: corbob

src/features/GetCommands.ts

@@ -4,6 +4,7 @@
 import * as vscode from "vscode";
 import { LanguageClient, RequestType } from "vscode-languageclient";
 import { IFeature } from "../feature";
+import { Logger } from "../logging";
 
 // TODO: Document this export: https://github.com/PowerShell/vscode-powershell/pull/1406#discussion_r209325655
 // TODO: Also use something other than any if possible... We may have already addressed this with a previous attempt.
@@ -14,13 +15,13 @@ export class GetCommandsFeature implements IFeature {
     private languageClient: LanguageClient;
     private commandsExplorerProvider: CommandsExplorerProvider;
 
-    constructor() {
+    constructor(private log: Logger) {
         this.command = vscode.commands.registerCommand("PowerShell.RefreshCommandsExplorer", () => {
             if (this.languageClient === undefined) {
-                // TODO: Log error message
+                this.log.writeAndShowError(`<${GetCommandsFeature.name}>: ` +
+                    "Unable to instantiate; language client undefined.");
                 return;
             }
-            // TODO: Refactor network code out of constructor
             this.languageClient.sendRequest(GetAllCommandsRequestType, "").then((result) => {
                 this.commandsExplorerProvider.powerShellCommands = result.map(toCommand);
                 this.commandsExplorerProvider.refresh();
@@ -102,10 +103,8 @@ class Command extends vscode.TreeItem {
         };
     }
 
-    public async getChildren(element): Promise<Command[]> {
+    public async getChildren(element?): Promise<Command[]> {
         return [];
-        // TODO: Determine why we're returning an empty array...
-        // I think it's because we have to return something and
-        // we're not actually using the tree view part just yet...
+        // Returning an empty array because we need to return something.
     }
 }

src/features/ShowHelp.ts

@@ -31,9 +31,9 @@ export class ShowHelpFeature implements IFeature {
                 const cwr = doc.getWordRangeAtPosition(selection.active);
                 const text = doc.getText(cwr);
 
-	            this.languageClient.sendRequest(ShowHelpRequestType, text);
+                this.languageClient.sendRequest(ShowHelpRequestType, text);
             } else {
-                this.languageClient.sendRequest(ShowOnlineHelpRequestType, item.Name);
+                this.languageClient.sendRequest(ShowHelpRequestType, item.Name);
             }
         });
 

src/main.ts

@@ -124,7 +124,7 @@ export function activate(context: vscode.ExtensionContext): void {
         new OpenInISEFeature(),
         new GenerateBugReportFeature(sessionManager),
         new ExpandAliasFeature(logger),
-        new GetCommandsFeature(),
+        new GetCommandsFeature(logger),
         new ShowHelpFeature(logger),
         new FindModuleFeature(),
         new PesterTestsFeature(sessionManager),
@@ -141,6 +141,7 @@ export function activate(context: vscode.ExtensionContext): void {
         new CustomViewsFeature(),
         new FoldingFeature(logger, documentSelector),
     ];
+
     sessionManager.setExtensionFeatures(extensionFeatures);
 
     if (extensionSettings.startAutomatically) {