Lowercase ACR package name when pushing to server (#1552)

Author: alerickson

src/code/ACRServerAPICalls.cs

@@ -1106,8 +1106,8 @@ internal bool PushNupkgACR(string psd1OrPs1File, string outputNupkgDir, string p
         {
             errRecord = null;
             // Push the nupkg to the appropriate repository
-            var fullNupkgFile = System.IO.Path.Combine(outputNupkgDir, pkgName + "." + pkgVersion.ToNormalizedString() + ".nupkg");
-
+            string fullNupkgFile = System.IO.Path.Combine(outputNupkgDir, pkgName + "." + pkgVersion.ToNormalizedString() + ".nupkg");
+            string pkgNameLower = pkgName.ToLower();
             string accessToken = string.Empty;
             string tenantID = string.Empty;
 
@@ -1136,7 +1136,8 @@ internal bool PushNupkgACR(string psd1OrPs1File, string outputNupkgDir, string p
 
             /* Uploading .nupkg */
             _cmdletPassedIn.WriteVerbose("Start uploading blob");
-            var moduleLocation = GetStartUploadBlobLocation(registry, pkgName, acrAccessToken).Result;
+            // Note:  ACR registries will only accept a name that is all lowercase.
+            var moduleLocation = GetStartUploadBlobLocation(registry, pkgNameLower, acrAccessToken).Result;
 
             _cmdletPassedIn.WriteVerbose("Computing digest for .nupkg file");
             bool nupkgDigestCreated = CreateDigest(fullNupkgFile, out string nupkgDigest, out ErrorRecord nupkgDigestError);
@@ -1159,7 +1160,7 @@ internal bool PushNupkgACR(string psd1OrPs1File, string outputNupkgDir, string p
             }
             using (FileStream configStream = new FileStream(emptyFilePath, FileMode.Create)){ }
             _cmdletPassedIn.WriteVerbose("Start uploading an empty file");
-            var emptyLocation = GetStartUploadBlobLocation(registry, pkgName, acrAccessToken).Result;
+            var emptyLocation = GetStartUploadBlobLocation(registry, pkgNameLower, acrAccessToken).Result;
             _cmdletPassedIn.WriteVerbose("Computing digest for empty file");
             bool emptyDigestCreated = CreateDigest(emptyFilePath, out string emptyDigest, out ErrorRecord emptyDigestError);
             if (!emptyDigestCreated)
@@ -1200,7 +1201,7 @@ internal bool PushNupkgACR(string psd1OrPs1File, string outputNupkgDir, string p
             File.WriteAllText(configFilePath, fileContent);
 
             _cmdletPassedIn.WriteVerbose("Create the manifest layer");
-            bool manifestCreated = CreateManifest(registry, pkgName, pkgVersion.OriginalVersion, configFilePath, true, acrAccessToken).Result;
+            bool manifestCreated = CreateManifest(registry, pkgNameLower, pkgVersion.OriginalVersion, configFilePath, true, acrAccessToken).Result;
 
             if (manifestCreated)
             {