Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EsrpSign.yml@ComplianceRepo could leverage yaml arrays #19

Open
TylerLeonhardt opened this issue Nov 23, 2020 · 4 comments
Open

EsrpSign.yml@ComplianceRepo could leverage yaml arrays #19

TylerLeonhardt opened this issue Nov 23, 2020 · 4 comments

Comments

@TylerLeonhardt
Copy link
Member

Currently pattern is a string with commas in it:

pattern: 'Microsoft.PowerShell.*.dll,Microsoft.PowerShell.*.psd1,Microsoft.PowerShell.*.psm1'

It would be nice if this could be:

pattern:
  - 'Microsoft.PowerShell.*.dll'
  - 'Microsoft.PowerShell.*.psd1'
  - 'Microsoft.PowerShell.*.psm1'

to align better with YAML.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.85. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@adityapatwardhan
Copy link
Member

The ESRP service needs it to be a string right now.

@TylerLeonhardt
Copy link
Member Author

Is it possible to give them that feedback?

@adityapatwardhan
Copy link
Member

Minimatch support has been added. I believe that is sufficient. Please close if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants