Merge pull request #45 from ahouene/s3-load-memleak

ahouene · web-flow · commit f18c634ecdf9 · 2023-06-28T12:27:42.000+02:00
S3 backend: add missing Close method call for Minio GetObject
diff --git a/backends/s3/s3.go b/backends/s3/s3.go
@@ -212,6 +212,7 @@ func (b *Backend) Load(ctx context.Context, name string) ([]byte, error) {
 	} else if obj == nil {
 		return nil, os.ErrNotExist
 	}
+	defer obj.Close()
 
 	p, err := io.ReadAll(obj)
 	if err = convertMinioError(err, false); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,7 @@ func (b *Backend) Load(ctx context.Context, name string) ([]byte, error) {`
`212`	`212`	`} else if obj == nil {`
`213`	`213`	`return nil, os.ErrNotExist`
`214`	`214`	`}`
	`215`	`+ defer obj.Close()`
`215`	`216`
`216`	`217`	`p, err := io.ReadAll(obj)`
`217`	`218`	`if err = convertMinioError(err, false); err != nil {`