s3: better error message for refresh_secrets

ahouene · wojas · web-flow · commit 0c624b393f5d · 2023-09-14T08:16:24.000+02:00
Co-authored-by: wojas &lt;github@m.wojas.nl&gt;
diff --git a/backends/s3/s3.go b/backends/s3/s3.go
@@ -118,7 +118,7 @@ func (o Options) Check() error {
 		return fmt.Errorf("s3 storage.options: credentials are required, fill either (access_key and secret_key) or (access_key_filename and secret_key_filename)")
 	}
 	if hasSecretsCreds && o.SecretsRefreshInterval < time.Second {
-		return fmt.Errorf("s3 storage.options: field refresh_secrets is required when using secret credentials")
+		return fmt.Errorf("s3 storage.options: field secrets_refresh_interval must be at least 1s")
 	}
 	if o.Bucket == "" {
 		return fmt.Errorf("s3 storage.options: bucket is required")

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ func (o Options) Check() error {`
`118`	`118`	`return fmt.Errorf("s3 storage.options: credentials are required, fill either (access_key and secret_key) or (access_key_filename and secret_key_filename)")`
`119`	`119`	`}`
`120`	`120`	`if hasSecretsCreds && o.SecretsRefreshInterval < time.Second {`
`121`		`- return fmt.Errorf("s3 storage.options: field refresh_secrets is required when using secret credentials")`
	`121`	`+ return fmt.Errorf("s3 storage.options: field secrets_refresh_interval must be at least 1s")`
`122`	`122`	`}`
`123`	`123`	`if o.Bucket == "" {`
`124`	`124`	`return fmt.Errorf("s3 storage.options: bucket is required")`