Skip to content

fix(base_client): return recursive _request() result on retry #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naresh4dev wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(base_client): return recursive _request() result on retry #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions portkey_ai/api_resources/base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ def _request(
# to completion before attempting to access the response text.

if retry_count < self.max_retries and self._should_retry(err.response):
self._request(
return self._request(
options=options,
stream=stream,
cast_to=cast_to,
Expand All @@ -688,7 +688,7 @@ def _request(
raise APITimeoutError(request=request) from err
except Exception as err:
if retry_count < self.max_retries:
self._request(
return self._request(
options=options,
stream=stream,
cast_to=cast_to,
Expand Down Expand Up @@ -1388,7 +1388,7 @@ async def _request(
# If the response is streamed then we need to explicitly read the response
# to completion before attempting to access the response text.
if retry_count < self.max_retries and self._should_retry(err.response):
await self._request(
return await self._request(
options=options,
stream=stream,
cast_to=cast_to,
Expand All @@ -1401,7 +1401,7 @@ async def _request(
raise APITimeoutError(request=request) from err
except Exception as err:
if retry_count < self.max_retries:
await self._request(
return await self._request(
options=options,
stream=stream,
cast_to=cast_to,
Expand Down
Loading