Skip to content

Improve web3 reconnection logic in offchain #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
monitz87 opened this issue Oct 11, 2018 · 0 comments
Closed

Improve web3 reconnection logic in offchain #87

monitz87 opened this issue Oct 11, 2018 · 0 comments
Labels
Github For Asana integration use only technical debt Maintainability improvements

Comments

@monitz87
Copy link
Contributor

Right now offchain sets no timeout between reconnection attempts. Not only is this pretty intensive in CPU and memory, it may also cause reconnection to fail (since it doesn't give any time for the socket to check if the connection was properly established before pinging again). It may also be attempting multiple reconnections at once (since there are 3 listeners). This may have to be revisited and improved, but there is a pending PR in web3 that handles all of this (including resubscribing to events)

The conflicting scenario arises when you start the local blockchain, start offchain and then shut the local blockchain down.

@monitz87 monitz87 added technical debt Maintainability improvements Github For Asana integration use only labels Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github For Asana integration use only technical debt Maintainability improvements
Projects
None yet
Development

No branches or pull requests

1 participant