Skip to content

Commit d51f38f

Browse files
One more green test
1 parent 0f23df7 commit d51f38f

File tree

5 files changed

+26
-13
lines changed

5 files changed

+26
-13
lines changed

Mathematics-Groups/Group.class.st

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ Group >> orderOf: anElement boundedBy: n [
715715

716716
{ #category : #morphisms }
717717
Group >> outerAutomorphisms [
718-
^ self automorphisms / self innerAutomorphisms
718+
^ self automorphisms / self innerAutomorphisms
719719
]
720720

721721
{ #category : #operations }
@@ -763,7 +763,14 @@ Group >> random [
763763

764764
{ #category : #morphisms }
765765
Group >> rightAction [
766-
^ GroupAction from: (self, self) to: self evaluatingWithArguments: [:x :y| self operation value: {y. self inverseMap value: x}]
766+
^ GroupAction
767+
from: self , self
768+
to: self
769+
evaluatingWithArguments: [ :x :y |
770+
self operation
771+
value:
772+
{y.
773+
(self inverseMap value: x)} ]
767774
]
768775

769776
{ #category : #morphisms }

Mathematics-Groups/QuotientGroup.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ QuotientGroup >> buildProjection [
3535
"Answer the natural projection, or quotient map, or canonical homomorphism. This takes elements from the base group to the corresponding coset in the quotient group."
3636
| answer |
3737
answer := self base to: self evaluating: [:each| self project: each].
38-
answer name: Character pi asString.
38+
answer name: 'Pi'. "Character pi asString"
3939
answer properties
4040
at: #kernel put: self relations;
4141
at: #image put: self;

Mathematics-Kernel-Support/Infinity.class.st

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@ Infinity >> positive [
176176
{ #category : #printing }
177177
Infinity >> printOn: aStream [
178178
self negative ifTrue: [aStream nextPut: $-].
179-
aStream nextPut: Character infinity
180-
" aStream nextPutAll: 'infinity'"
179+
"aStream nextPut: Character infinity"
180+
aStream nextPutAll: 'infinity'
181181
]
182182

183183
{ #category : #arithmetic }

Mathematics-Kernel/Domain.class.st

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,8 @@ Domain >> asSet [
243243
{ #category : #random }
244244
Domain >> atRandom [
245245
"Answer an element in the receiver choosen at random. This will fail if the receiver is not finite."
246-
^ Random withDefaultDo: [:aRandom| self atRandom: aRandom]
246+
"^ Random withDefaultDo: [:aRandom| self atRandom: aRandom]" "Cuis specific"
247+
^self atRandom: Random new
247248
]
248249

249250
{ #category : #random }
@@ -263,7 +264,8 @@ Domain >> atRandom: aRandom bits: bitSize [
263264
{ #category : #random }
264265
Domain >> atRandomBits: bitSize [
265266
"Answer an element of the receiver of at most n bits (as measured by #bitSize). The total number of elements that could be returned shouldn't exceed 2^n."
266-
^ Random withDefaultDo: [:aRandom| self atRandom: aRandom bits: bitSize]
267+
"^ Random withDefaultDo: [:aRandom| self atRandom: aRandom bits: bitSize]" "Cuis specific"
268+
^ self atRandom: Random new bits: bitSize
267269
]
268270

269271
{ #category : #morphisms }

MathematicsTests/GroupTest.class.st

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,13 @@ GroupTest >> testGroupRing [
166166
xa := R embed: a.
167167
xb := R embed: b.
168168
xc := R embed: c.
169-
self assert: xa*xb = (R embed: a*b).
170-
self assert: xa*2 + xb*xc - (xa*xc) - (xb*xc) = (R embed: a*c).
171-
'self assert: (xa + xb) * (xa - xb) = (xa^2 - (xb^2) + (xb*xa) - (xa*xb))'
169+
self assert: xa * xb equals: (R embed: a * b).
170+
self
171+
assert: (xa * 2 + xb) * xc - (xa * xc) - (xb * xc)
172+
equals: (R embed: a * c).
173+
self
174+
assert: (xa + xb) * (xa - xb)
175+
equals: (xa raisedTo: 2) - (xb raisedTo: 2) + (xb * xa) - (xa * xb)
172176
]
173177

174178
{ #category : #tests }
@@ -274,14 +278,14 @@ GroupTest >> testPermutationGroupHomomorphism [
274278
GroupTest >> testQuotientGroup [
275279
| G N Q pi h |
276280
G := Group integersMod: 6.
277-
N := G span: {3 % 6}.
281+
N := G span: {(3 % 6)}.
278282
Q := G / N.
279-
self assert: Q size = 3.
283+
self assert: Q size equals: 3.
280284
self testGroup: Q.
281285
pi := Q projection.
282286
self assert: (Q includes: (pi value: G atRandom)).
283287
h := Q atRandom.
284-
self assert: (pi value: (pi section value: h)) = h.
288+
self assert: (pi value: (pi section value: h)) equals: h.
285289
self testGroupHomomorphism: pi
286290
]
287291

0 commit comments

Comments
 (0)