fix: Rename region_id and base_form_id to region and base_form in evolution details

For consistency with other fields (e.g. trade_species_id -> trade_species),
evolution detail fields should omit the _id suffix. The serializer was
manually naming them with _id, diverging from the documented API response.

Fixes #1396

Author: santichausis

openapi.yml

@@ -4040,8 +4040,8 @@ components:
                       - trigger
                       - turn_upside_down
                       - used_move
-                      - region_id
-                      - base_form_id
+                      - region
+                      - base_form
                       properties:
                         gender:
                           type: object
@@ -4173,7 +4173,7 @@ components:
                         used_move:
                           type: ''
                           nullable: true
-                        region_id:
+                        region:
                           type: object
                           nullable: true
                           required:
@@ -4185,7 +4185,7 @@ components:
                             url:
                               type: string
                               format: uri
-                        base_form_id:
+                        base_form:
                           type: object
                           nullable: true
                           required:

pokemon_v2/serializers.py

@@ -5637,8 +5637,8 @@ class PokemonEvolutionSerializer(serializers.ModelSerializer):
     trade_species = PokemonSpeciesSummarySerializer()
     location = LocationSummarySerializer()
     trigger = EvolutionTriggerSummarySerializer(source="evolution_trigger")
-    region_id = RegionSummarySerializer(source="region")
-    base_form_id = PokemonSpeciesSummarySerializer(source="base_form")
+    region = RegionSummarySerializer()
+    base_form = PokemonSpeciesSummarySerializer()
     used_move = MoveSummarySerializer()
 
     class Meta:
@@ -5663,8 +5663,8 @@ class Meta:
             "time_of_day",
             "trade_species",
             "turn_upside_down",
-            "region_id",
-            "base_form_id",
+            "region",
+            "base_form",
             "used_move",
             "min_move_count",
             "min_steps",
@@ -5726,8 +5726,8 @@ class Meta:
                                         "trigger",
                                         "turn_upside_down",
                                         "used_move",
-                                        "region_id",
-                                        "base_form_id",
+                                        "region",
+                                        "base_form",
                                     ],
                                     "properties": {
                                         "gender": {
@@ -5879,7 +5879,7 @@ class Meta:
                                             "type": "",
                                             "nullable": True,
                                         },
-                                        "region_id": {
+                                        "region": {
                                             "type": "object",
                                             "nullable": True,
                                             "required": ["name", "url"],
@@ -5891,7 +5891,7 @@ class Meta:
                                                 },
                                             },
                                         },
-                                        "base_form_id": {
+                                        "base_form": {
                                             "type": "object",
                                             "nullable": True,
                                             "required": ["name", "url"],