Skip to content

[BUG] rollback+restore can place water in the nether #857

@guss-alberto

Description

@guss-alberto

Steps to reproduce:

  1. enter the Nether
  2. right click with a Water Bucket on the ground, which should only play a particle effect
  3. execute the command /co rollback t:10m r:10 a:block
  4. execute the command /co undo to restore the rolled back actions

Expected result:

Nothing should be rolled back and nothing should be restored.

Observed result:

Nothing is rollback, but upon restoring water gets placed illegally in the Nether.

This issue comes from the fact water placement is logged regardless of whether it succeeds or not.

Possible fixes:

  • Ignore Material.WATER entries in RollbackBlockHandler if bukkitWorld.isUltraWarm()
  • Do not log Material.WATER placement in BlockPlaceLogger when eventLocation.getWorld().isUltraWarm()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions