Shopify & Shopify Developer App - make additionalProps optional in Update Metaobject action (#7385)

* bug fix & props optional

* handle various field types

* pnpm-lock.yaml

Author: michelle0927

components/shopify/actions/update-metaobject/common.mjs

@@ -32,11 +32,25 @@ export default {
       id: this.metaobject,
     });
     for (const field of fields) {
+      const type = consts.METAFIELD_TYPES[field.type];
       props[field.key] = {
-        type: consts.METAFIELD_TYPES[field.type],
+        type,
         label: field.definition.name,
-        default: field.value,
+        optional: true,
       };
+      if (field.value) {
+        if (type === "integer") {
+          props[field.key].default = parseInt(field.value);
+        } else if (type === "boolean") {
+          props[field.key].default = field.value === "true"
+            ? true
+            : false;
+        } else if (type === "object" || type === "string[]") {
+          props[field.key].default = JSON.parse(field.value);
+        } else {
+          props[field.key].default = field.value;
+        }
+      }
     }
     return props;
   },
@@ -47,9 +61,14 @@ export default {
 
     const newFields = [];
     for (const field of fields) {
+      const fieldValue = this[field.key]
+        ? this[field.key]
+        : field.value || "";
       newFields.push({
         key: field.key,
-        value: this[field.key],
+        value: typeof fieldValue === "string"
+          ? fieldValue
+          : JSON.stringify(fieldValue),
       });
     }
 
@@ -59,10 +78,18 @@ export default {
       $,
     });
 
-    if (response) {
-      $.export("$summary", `Successfully updated metaobject with ID ${this.metaobject}`);
+    let errorMessage;
+    if (response?.errors?.length) {
+      errorMessage = response.errors[0].message;
+    }
+    if (response?.data?.metaobjectUpdate?.userErrors?.length) {
+      errorMessage = response.data.metaobjectUpdate.userErrors[0].message;
+    }
+    if (errorMessage) {
+      throw new Error(`${errorMessage}`);
     }
 
+    $.export("$summary", `Successfully updated metaobject with ID ${this.metaobject}`);
     return response;
   },
 };

components/shopify/actions/update-metaobject/update-metaobject.mjs

@@ -8,7 +8,7 @@ export default {
   key: "shopify-update-metaobject",
   name: "Update Metaobject",
   description: "Updates a metaobject. [See the documentation](https://shopify.dev/docs/api/admin-graphql/2023-04/mutations/metaobjectUpdate)",
-  version: "0.0.2",
+  version: "0.0.3",
   type: "action",
   props: {
     shopify,

components/shopify/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pipedream/shopify",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "description": "Pipedream Shopify Components",
   "main": "shopify.app.mjs",
   "keywords": [

components/shopify_developer_app/actions/update-metaobject/update-metaobject.mjs

@@ -8,7 +8,7 @@ export default {
   key: "shopify_developer_app-update-metaobject",
   name: "Update Metaobject",
   description: "Updates a metaobject. [See the documentation](https://shopify.dev/docs/api/admin-graphql/2023-04/mutations/metaobjectUpdate)",
-  version: "0.0.1",
+  version: "0.0.2",
   type: "action",
   props: {
     shopify,

components/shopify_developer_app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pipedream/shopify_developer_app",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Pipedream Shopify (Developer App) Components",
   "main": "shopify_developer_app.app.mjs",
   "keywords": [